Skip crawling into CSS requests when crawling module graph #10911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7ef09fb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Princesseuh
approved these changes
Apr 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Unblocks vitejs/vite#16455
We were crawling into dependencies of CSS vite modules, which are usually not needed as these dependencies (especially CSS) are already inlined into the parent vite module.
In practice, this doesn't change the output as we coincidentally these dependencies don't have an
id:astro/packages/astro/src/vite-plugin-astro-server/vite.ts
Lines 46 to 47 in 05d58ef
So they were skipped. But vitejs/vite#16455 will change things slightly that makes this not work, so this PR makes this skip more explicit.
Testing
Ran tests locally, and tested an example manually.
Docs
n/a. internal change.