-
-
Notifications
You must be signed in to change notification settings - Fork 3k
[db] Fix duplicate calls to recreate tables on startup #10919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+211
−182
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
3c19e9c
fix: move recreateTables() to integration hooks
bholmesdev 4427383
feat: recreate and seed at load, not in virtual runtime
bholmesdev 333131b
feat: eager build db on startup and seed file change
bholmesdev 2c6de6b
fix: respect database_file in dbUrl
bholmesdev 56c4c97
chore: remove duplicate recreateTables call
bholmesdev 82ad425
chore: remove now self-explanatory comments
bholmesdev a901140
fix: remove invalidateModule call for eager loading
bholmesdev 69b1f77
feat: respect seed package paths
bholmesdev 4abe41d
fix: remove duplicate recreateTables() call
bholmesdev 1ed4c02
refactor: move recreateTables() to vite-plugin-db
bholmesdev 4694c8e
refactor: move queries.ts from runtime/ to core/
bholmesdev 98b1491
fix: update test import to core/queries
bholmesdev 026062e
refactor: move executeSeedFile to vite-plugin-db
bholmesdev fe7a947
refactor: extract seeding and recreating to helper fns
bholmesdev c15b585
chore: changeset
bholmesdev 533edb2
chore: revert connectToStudio refactor
bholmesdev d8b46db
wip: log db url
bholmesdev 6f6fef2
fix(test): normalize astro_database_file flag for windows
bholmesdev 01cca1c
Revert "wip: log db url"
bholmesdev 53ed848
Revert "Revert "wip: log db url""
bholmesdev 33747cb
fix: correctly resolve relative paths with unit test
bholmesdev a390dbd
chore: remove unused dbDirPath
bholmesdev f81cf8b
chore: remove unused import
bholmesdev 9ba3d60
chore: remove unused type
bholmesdev 1b41be4
fix: remove bad import
bholmesdev 3b014fd
[db] Load seed files with vite dev server (#10941)
bholmesdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: move executeSeedFile to vite-plugin-db
- Loading branch information
commit 026062ef3b0590093134c5fb2bbbb757edc1ec7a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.