Skip to content

Fixes ASTRO_DATABASE_FILE interaction with relative paths #10925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewp merged 1 commit into from
May 1, 2024
Merged

Fixes ASTRO_DATABASE_FILE interaction with relative paths #10925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: changeset
  • Loading branch information
@Princesseuh
Princesseuh committed May 1, 2024
commit 2e96f997196e3ced6fffc67a63ca9c1a46b3e10c
5 changes: 5 additions & 0 deletions .changeset/olive-cars-run.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@astrojs/db": patch
---

Fixes `ASTRO_DATABASE_FILE` not correctly resolving relative paths (e.g. `ASTRO_DATABASE_FILE=./api/database.db`
3 changes: 2 additions & 1 deletion packages/db/src/runtime/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ export function normalizeDatabaseUrl(envDbUrl: string | undefined, defaultDbUrl:
if (envDbUrl.startsWith('file://')) {
return envDbUrl;
}
return new URL(envDbUrl, pathToFileURL(process.cwd())).toString();

return new URL(envDbUrl, pathToFileURL(process.cwd()) + "/").toString();
} else {
// This is going to be a file URL always,
return defaultDbUrl;
Expand Down