Skip to content

refactor: dedicated App for astro server and for external servers #14345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ematipico merged 7 commits into from
Sep 15, 2025
Merged

refactor: dedicated App for astro server and for external servers #14345

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
93b9fe2
refactor: dev app without settings and loader
ematipico Sep 11, 2025
6656b77
address comments
ematipico Sep 12, 2025
1202d66
chore: refactor to use proper dev pipeline
ematipico Sep 12, 2025
414ff0c
revert changes
ematipico Sep 12, 2025
3021455
chore: update lockfile
ematipico Sep 12, 2025
ee5eb8b
conditionally propagate metadata
ematipico Sep 12, 2025
4327fed
revert exports
ematipico Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/astro/src/vite-plugin-head/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export default function configHeadVitePlugin(): vite.Plugin {
if (result) {
let info = this.getModuleInfo(result.id);
const astro = info && getAstroMetadata(info);
if (astro) {
if (astro && isRunnableDevEnvironment(environment)) {
Copy link
Contributor

@ascorbic ascorbic Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this not work with other envionrments?

Copy link
Member Author

@ematipico ematipico Sep 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the question, but without this guard, the Cloudflare plugin emits errors

Copy link
Contributor

@ascorbic ascorbic Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant remove the guard in configureServer instead, so that it populates environment and can run in workerd too

if (astro.propagation === 'self' || astro.propagation === 'in-tree') {
propagateMetadata.call(this, importer, 'propagation', 'in-tree');
}
Expand All @@ -77,6 +77,9 @@ export default function configHeadVitePlugin(): vite.Plugin {
}
},
transform(source, id) {
if (!isRunnableDevEnvironment(environment)) {
return;
}
// TODO This could probably be removed now that this is handled in resolveId
let info = this.getModuleInfo(id);
if (info && getAstroMetadata(info)?.containsHead) {
Expand Down
Loading