Skip to content

environments: get images to build in fixture #14599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewp merged 1 commit into from
Oct 22, 2025
Merged

environments: get images to build in fixture #14599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/integrations/cloudflare/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,8 @@ export default function createIntegration(args?: Options): AstroIntegration {
vite.build.rollupOptions.output.banner ||=
'globalThis.process ??= {}; globalThis.process.env ??= {};';

vite.build.rollupOptions.external = ['sharp'];

// Cloudflare env is only available per request. This isn't feasible for code that access env vars
// in a global way, so we shim their access as `process.env.*`. This is not the recommended way for users to access environment variables. But we'll add this for compatibility for chosen variables. Mainly to support `@astrojs/db`
vite.define = {
Expand Down
12 changes: 7 additions & 5 deletions packages/integrations/cloudflare/test/fixtures/vite-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,18 @@
"version": "0.0.0",
"private": true,
"scripts": {
"dev": "astro dev"
"dev": "astro dev",
"build": "astro build"
},
"dependencies": {
"@astrojs/cloudflare": "workspace:*",
"@astrojs/mdx": "^4.3.5",
"@astrojs/react": "workspace:*",
"@types/react": "^18.3.24",
"@types/react-dom": "^18.3.7",
"astro": "workspace:*",
"@types/react": "^18.3.24",
"@types/react-dom": "^18.3.7",
"react": "^18.3.1",
"react-dom": "^18.3.1"
"react": "^18.3.1",
"react-dom": "^18.3.1",
"sharp": "^0.34.3"
}
}
3 changes: 3 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading