Skip to content

fix: resolve environment-api build issues for client & CSS #14770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewp merged 6 commits into from
Nov 17, 2025
Merged

fix: resolve environment-api build issues for client & CSS #14770

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
185ec37
fix: resolve environment-api build issues for client & CSS
matthewp Nov 15, 2025
3b4d68f
fix lint
matthewp Nov 15, 2025
c934f63
properly emit assets
matthewp Nov 16, 2025
c65ae92
address PR comments
matthewp Nov 17, 2025
5768c75
fix build
matthewp Nov 17, 2025
3fa1331
fix lint
matthewp Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix build
  • Loading branch information
@matthewp
matthewp committed Nov 17, 2025
commit 5768c75b5c0ee6d2e795783ea7e182f7965fa38b
1 change: 0 additions & 1 deletion packages/astro/src/core/build/generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ import { stringifyParams } from '../routing/params.js';
import { getOutputFilename } from '../util.js';
import { getOutFile, getOutFolder } from './common.js';
import { type BuildInternals, hasPrerenderedPages } from './internal.js';
import { PRERENDER_ENTRY_FILENAME_PREFIX } from './static-build.js';
import { BuildPipeline } from './pipeline.js';
import type { SinglePageBuiltModule, StaticBuildOptions } from './types.js';
import { getTimeStat, shouldAppendForwardSlash } from './util.js';
Expand Down
6 changes: 3 additions & 3 deletions packages/astro/src/core/build/static-build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,9 +282,9 @@ type MutateChunk = (chunk: vite.Rollup.OutputChunk, targets: string[], newCode:
* Throws an error if no prerender entry file is found.
*/
function getPrerenderEntryFileName(
prerenderOutput: vite.Rollup.RollupOutput | vite.Rollup.RollupOutput[],
prerenderOutput: vite.Rollup.RollupOutput | vite.Rollup.RollupOutput[] | vite.Rollup.RollupWatcher,
): string {
const outputs = Array.isArray(prerenderOutput) ? prerenderOutput : [prerenderOutput];
const outputs = viteBuildReturnToRollupOutputs(prerenderOutput as any);

for (const output of outputs) {
for (const chunk of output.output) {
Expand All @@ -308,7 +308,7 @@ function getPrerenderEntryFileName(
*/
function extractPrerenderEntryFileName(
internals: BuildInternals,
prerenderOutput: vite.Rollup.RollupOutput | vite.Rollup.RollupOutput[],
prerenderOutput: vite.Rollup.RollupOutput | vite.Rollup.RollupOutput[] | vite.Rollup.RollupWatcher,
) {
internals.prerenderEntryFileName = getPrerenderEntryFileName(prerenderOutput);
}
Expand Down
Loading