Skip to content

fix: hashing of chunks #14811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ematipico merged 2 commits into from
Nov 20, 2025
Merged

fix: hashing of chunks #14811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e510bc
fix: hashing of chunks
ematipico Nov 19, 2025
63cee82
address feedback
ematipico Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/astro/src/manifest/serialized.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,13 @@ export function serializedManifestPlugin({
name: SERIALIZED_MANIFEST_ID,
enforce: 'pre',

augmentChunkHash(information) {
// We only augment the hash of this entrypoint
if (information.name === 'prerender') {
return Date.now().toString();
}
},

resolveId(id) {
if (id === SERIALIZED_MANIFEST_ID) {
return SERIALIZED_MANIFEST_RESOLVED_ID;
Expand Down
271 changes: 135 additions & 136 deletions packages/astro/test/i18n-routing.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,174 +1208,173 @@ describe('[SSG] i18n routing', () => {
});
});

describe('current locale', () => {
describe('with [prefix-other-locales]', () => {
/** @type {import('./test-utils').Fixture} */
let fixture;

before(async () => {
fixture = await loadFixture({
root: './fixtures/i18n-routing/',
});
await fixture.build();
});
describe('with [prefix-other-locales]', () => {
Copy link
Member Author

@ematipico ematipico Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just extracted some describe and moved them to the top-level. This will help with adding .only to fewer blocks

/** @type {import('./test-utils').Fixture} */
let fixture;

it('should return the default locale', async () => {
let html = await fixture.readFile('/current-locale/index.html');
assert.equal(html.includes('Current Locale: es'), true);
before(async () => {
fixture = await loadFixture({
root: './fixtures/i18n-routing/',
});
await fixture.build();
});

it('should return the default locale when rendering a route with spread operator', async () => {
const html = await fixture.readFile('/blog/es/index.html');
assert.equal(html.includes('Current Locale: es'), true);
});
it('should return the default locale', async () => {
let html = await fixture.readFile('/current-locale/index.html');
assert.equal(html.includes('Current Locale: es'), true);
});

it('should return the default locale of the current URL', async () => {
const html = await fixture.readFile('/pt/start/index.html');
assert.equal(html.includes('Current Locale: pt'), true);
});
it('should return the default locale when rendering a route with spread operator', async () => {
const html = await fixture.readFile('/blog/es/index.html');
assert.equal(html.includes('Current Locale: es'), true);
});

it('should return the default locale when a route is dynamic', async () => {
const html = await fixture.readFile('/dynamic/lorem/index.html');
assert.equal(html.includes('Current Locale: es'), true);
});
it('should return the default locale of the current URL', async () => {
const html = await fixture.readFile('/pt/start/index.html');
assert.equal(html.includes('Current Locale: pt'), true);
});

it('should returns the correct locale when requesting a locale via path', async () => {
const html = await fixture.readFile('/spanish/index.html');
assert.equal(html.includes('Current Locale: es'), true);
});
it('should return the default locale when a route is dynamic', async () => {
const html = await fixture.readFile('/dynamic/lorem/index.html');
assert.equal(html.includes('Current Locale: es'), true);
});

describe('with [pathname-prefix-always]', () => {
/** @type {import('./test-utils').Fixture} */
let fixture;
it('should returns the correct locale when requesting a locale via path', async () => {
const html = await fixture.readFile('/spanish/index.html');
assert.equal(html.includes('Current Locale: es'), true);
});
});

before(async () => {
fixture = await loadFixture({
root: './fixtures/i18n-routing-prefix-always/',
});
await fixture.build();
});
describe('with [pathname-prefix-always]', () => {
/** @type {import('./test-utils').Fixture} */
let fixture;

it('should return the locale of the current URL (en)', async () => {
const html = await fixture.readFile('/en/start/index.html');
assert.equal(html.includes('Current Locale: en'), true);
before(async () => {
fixture = await loadFixture({
root: './fixtures/i18n-routing-prefix-always/',
});
await fixture.build();
});

it('should return the locale of the current URL (pt)', async () => {
const html = await fixture.readFile('/pt/start/index.html');
assert.equal(html.includes('Current Locale: pt'), true);
});
it('should return the locale of the current URL (en)', async () => {
const html = await fixture.readFile('/en/start/index.html');
assert.equal(html.includes('Current Locale: en'), true);
});

describe('when `build.format` is `file`, locales array contains objects, and locale indexes use getStaticPaths', () => {
/** @type {import('./test-utils').Fixture} */
let fixture;
it('should return the locale of the current URL (pt)', async () => {
const html = await fixture.readFile('/pt/start/index.html');
assert.equal(html.includes('Current Locale: pt'), true);
});
});

before(async () => {
fixture = await loadFixture({
root: './fixtures/i18n-locale-index-format-file/',
i18n: {
defaultLocale: 'en-us',
locales: [
{
path: 'en-us',
codes: ['en-US'],
},
{
path: 'es-mx',
codes: ['es-MX'],
},
{
path: 'fr-fr',
codes: ['fr-FR'],
},
],
routing: {
prefixDefaultLocale: true,
redirectToDefaultLocale: false,
},
},
});
await fixture.build();
});
describe('with dynamic paths', async () => {
/** @type {import('./test-utils').Fixture} */
let fixture;
let devServer;

it('should return the locale code of the current URL (en-US)', async () => {
const html = await fixture.readFile('/en-us.html');
assert.equal(html.includes('currentLocale: en-US'), true);
before(async () => {
fixture = await loadFixture({
root: './fixtures/i18n-routing/',
});
devServer = await fixture.startDevServer();
});

it('should return the locale code of the current URL (es-MX)', async () => {
const html = await fixture.readFile('/es-mx.html');
assert.equal(html.includes('currentLocale: es-MX'), true);
});
afterEach(async () => {
devServer.stop();
});

it('should return the locale code of the current URL (fr-FR)', async () => {
const html = await fixture.readFile('/fr-fr.html');
assert.equal(html.includes('currentLocale: fr-FR'), true);
});
it('should return the correct current locale', async () => {
let html = await fixture.fetch('/en').then((r) => r.text());
assert.match(html, /en/);
html = await fixture.fetch('/ru').then((r) => r.text());
assert.match(html, /ru/);
});
});
});

describe('when `build.format` is `file`, locales array contains strings, and locale indexes use getStaticPaths', () => {
/** @type {import('./test-utils').Fixture} */
let fixture;
describe('[SSG] i18n routing when `build.format` is `file`, locales array contains objects, and locale indexes use getStaticPaths', () => {
/** @type {import('./test-utils').Fixture} */
let fixture;

before(async () => {
fixture = await loadFixture({
root: './fixtures/i18n-locale-index-format-file/',
i18n: {
defaultLocale: 'en-us',
locales: ['en-us', 'es-mx', 'fr-fr'],
routing: {
prefixDefaultLocale: true,
redirectToDefaultLocale: false,
},
before(async () => {
fixture = await loadFixture({
root: './fixtures/i18n-locale-index-format-file/',
i18n: {
defaultLocale: 'en-us',
locales: [
{
path: 'en-us',
codes: ['en-US'],
},
});
await fixture.build();
});
{
path: 'es-mx',
codes: ['es-MX'],
},
{
path: 'fr-fr',
codes: ['fr-FR'],
},
],
routing: {
prefixDefaultLocale: true,
redirectToDefaultLocale: false,
},
},
});
await fixture.build();
});

it('should return the locale of the current URL (en-us)', async () => {
const html = await fixture.readFile('/en-us.html');
assert.equal(html.includes('currentLocale: en-us'), true);
});
it('should return the locale code of the current URL (en-US)', async () => {
const html = await fixture.readFile('/en-us.html');
assert.equal(html.includes('currentLocale: en-US'), true);
});

it('should return the locale of the current URL (es-mx)', async () => {
const html = await fixture.readFile('/es-mx.html');
assert.equal(html.includes('currentLocale: es-mx'), true);
});
it('should return the locale code of the current URL (es-MX)', async () => {
const html = await fixture.readFile('/es-mx.html');
assert.equal(html.includes('currentLocale: es-MX'), true);
});

it('should return the locale of the current URL (fr-fr)', async () => {
const html = await fixture.readFile('/fr-fr.html');
assert.equal(html.includes('currentLocale: fr-fr'), true);
});
});
it('should return the locale code of the current URL (fr-FR)', async () => {
const html = await fixture.readFile('/fr-fr.html');
assert.equal(html.includes('currentLocale: fr-FR'), true);
});
});

describe('with dynamic paths', async () => {
/** @type {import('./test-utils').Fixture} */
let fixture;
let devServer;
describe('[SSG] i18n routing when `build.format` is `file`, locales array contains strings, and locale indexes use getStaticPaths', () => {
/** @type {import('./test-utils').Fixture} */
let fixture;

before(async () => {
fixture = await loadFixture({
root: './fixtures/i18n-routing/',
});
devServer = await fixture.startDevServer();
});
before(async () => {
fixture = await loadFixture({
root: './fixtures/i18n-locale-index-format-file/',
i18n: {
defaultLocale: 'en-us',
locales: ['en-us', 'es-mx', 'fr-fr'],
routing: {
prefixDefaultLocale: true,
redirectToDefaultLocale: false,
},
},
});
await fixture.build();
});

afterEach(async () => {
devServer.stop();
});
it('should return the locale of the current URL (en-us)', async () => {
const html = await fixture.readFile('/en-us.html');
assert.equal(html.includes('currentLocale: en-us'), true);
});

it('should return the correct current locale', async () => {
let html = await fixture.fetch('/en').then((r) => r.text());
assert.match(html, /en/);
html = await fixture.fetch('/ru').then((r) => r.text());
assert.match(html, /ru/);
});
});
it('should return the locale of the current URL (es-mx)', async () => {
const html = await fixture.readFile('/es-mx.html');
assert.equal(html.includes('currentLocale: es-mx'), true);
});

it('should return the locale of the current URL (fr-fr)', async () => {
const html = await fixture.readFile('/fr-fr.html');
assert.equal(html.includes('currentLocale: fr-fr'), true);
});
});

describe('[SSR] i18n routing', () => {
let app;

Expand Down
Loading