Skip to content

Fix astro-css-bundling tests #14840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewp merged 2 commits into from
Nov 21, 2025
Merged

Fix astro-css-bundling tests #14840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec8c38a
Fix astro-component-bundling tests
matthewp Nov 20, 2025
4596b11
Merge branch 'feat/environment-api' into tests/astro-css-bundling
matthewp Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/astro/src/core/build/static-build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ async function buildEnvironments(opts: StaticBuildOptions, internals: BuildInter
output: {
entryFileNames: `${PRERENDER_ENTRY_FILENAME_PREFIX}.[hash].mjs`,
format: 'esm',
...viteConfig.environments?.prerender?.build?.rollupOptions?.output,
},
},
ssr: true,
Expand Down Expand Up @@ -245,6 +246,11 @@ async function buildEnvironments(opts: StaticBuildOptions, internals: BuildInter
ssr: {
build: {
outDir: fileURLToPath(getServerOutputDirectory(settings)),
rollupOptions: {
output: {
...viteConfig.environments?.ssr?.build?.rollupOptions?.output
}
}
},
},
},
Expand Down
29 changes: 17 additions & 12 deletions packages/astro/test/astro-css-bundling.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,17 +80,23 @@ describe('CSS Bundling', function () {
root: './fixtures/astro-css-bundling/',

// test suite was authored when inlineStylesheets defaulted to never
build: { inlineStylesheets: 'never' },
build: {
inlineStylesheets: 'never',
assets: 'assets',
},

vite: {
build: {
rollupOptions: {
output: {
assetFileNames: 'assets/[name][extname]',
entryFileNames: '[name].js',
},
},
},
environments: {
prerender: {
build: {
rollupOptions: {
output: {
assetFileNames: 'assets/[name][extname]',
}
}
}
}
}
},
});
await fixture.build({ mode: 'production' });
Expand All @@ -106,10 +112,9 @@ describe('CSS Bundling', function () {
assert.doesNotMatch(firstFound, /[a-z]+\.[\da-z]{8}\.css/);
});

it('there are 2 index named CSS files', async () => {
it('there are 4 css files (3 pages, one shared component)', async () => {
const dir = await fixture.readdir('/assets');
const indexNamedFiles = dir.filter((name) => name.startsWith('index'));
assert.equal(indexNamedFiles.length, 2);
assert.equal(dir.length, 4);
});
});
});
Loading