Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/astro/src/core/app/base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export interface RenderErrorOptions {
*/
error?: unknown;
clientAddress: string | undefined;
prerenderedErrorPageFetch: (url: ErrorPagePath) => Promise<Response>;
prerenderedErrorPageFetch: ((url: ErrorPagePath) => Promise<Response>) | undefined;
}

type ErrorPagePath =
Expand Down Expand Up @@ -500,7 +500,7 @@ export abstract class BaseApp<P extends Pipeline = AppPipeline> {
if (errorRouteData.prerender) {
const maybeDotHtml = errorRouteData.route.endsWith(`/${status}`) ? '.html' : '';
const statusURL = new URL(`${this.baseWithoutTrailingSlash}/${status}${maybeDotHtml}`, url);
if (statusURL.toString() !== request.url) {
if (statusURL.toString() !== request.url && prerenderedErrorPageFetch) {
const response = await prerenderedErrorPageFetch(statusURL.toString() as ErrorPagePath);

// In order for the response of the remote to be usable as a response
Expand Down
5 changes: 4 additions & 1 deletion packages/astro/src/core/build/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ export class BuildApp extends BaseApp<BuildPipeline> {
if (options.status === 500) {
throw options.error;
} else {
return super.renderError(request, options);
return super.renderError(request, {
...options,
prerenderedErrorPageFetch: undefined
});
}
}
}
Loading