Skip to content

Conversation

@Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Dec 9, 2025

Changes

Fixes #14962

Testing

Added a test

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2025

🦋 Changeset detected

Latest commit: af9e8ae

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 9, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 9, 2025

CodSpeed Performance Report

Merging #14987 will not alter performance

Comparing fix/passthrough-svgs (af9e8ae) with main (9dd9fca)1

Summary

✅ 6 untouched

Footnotes

  1. No successful run was found on main (16f3994) during the generation of this report, so 9dd9fca was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Princesseuh Princesseuh marked this pull request as ready for review December 10, 2025 14:58
@Princesseuh
Copy link
Member Author

The tests passes locally but not in CI, will figure it out

@Princesseuh Princesseuh marked this pull request as draft December 10, 2025 15:45
@Princesseuh Princesseuh marked this pull request as ready for review December 12, 2025 14:30
Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it just needs a patch changeset

@Princesseuh Princesseuh merged commit 9dd9fca into main Dec 12, 2025
6 checks passed
@Princesseuh Princesseuh deleted the fix/passthrough-svgs branch December 12, 2025 15:02
@astrobot-houston astrobot-houston mentioned this pull request Dec 12, 2025
florian-lefebvre added a commit that referenced this pull request Dec 16, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Emanuele Stoppa <[email protected]>
Co-authored-by: Matt Kane <[email protected]>
Co-authored-by:  Matthew Phillips <[email protected]>
Co-authored-by: Matthew Phillips <[email protected]>
Co-authored-by: Erika <[email protected]>
Co-authored-by: Antony Faris <[email protected]>
Co-authored-by: Erika <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Houston (Bot) <[email protected]>
Co-authored-by: Florian Lefebvre <[email protected]>
fix(ci): Reinstall deps after having published VS Code (#14996)
fix(svelte): allow client directives (#15004)
fix(assets): Fixes missing format option for svgs in the passthrough service (#14987)
fix(deps): update all non-major dependencies (#15020)
fix(content-layer): Try a smarter solution to normalize bare image paths in JSON (#15028)
fix(astro): assets vite build log (#15034)
resolved (#15033)
dadezzz pushed a commit to dadezzz/ice-notes that referenced this pull request Dec 19, 2025
This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [astro](https://astro.build) ([source](https://github.com/withastro/astro/tree/HEAD/packages/astro)) | [`5.16.5` -> `5.16.6`](https://renovatebot.com/diffs/npm/astro/5.16.5/5.16.6) | ![age](https://developer.mend.io/api/mc/badges/age/npm/astro/5.16.6?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/astro/5.16.5/5.16.6?slim=true) |

---

### Release Notes

<details>
<summary>withastro/astro (astro)</summary>

### [`v5.16.6`](https://github.com/withastro/astro/blob/HEAD/packages/astro/CHANGELOG.md#5166)

[Compare Source](https://github.com/withastro/astro/compare/[email protected]@5.16.6)

##### Patch Changes

- [#&#8203;14982](withastro/astro#14982) [`6849e38`](withastro/astro@6849e38) Thanks [@&#8203;Princesseuh](https://github.com/Princesseuh)! - Fixes images outside the project directory not working when using astro:assets in development mode

- [#&#8203;14987](withastro/astro#14987) [`9dd9fca`](withastro/astro@9dd9fca) Thanks [@&#8203;Princesseuh](https://github.com/Princesseuh)! - Fixes SVGs not working in dev mode when using the passthrough image service

- [#&#8203;15014](withastro/astro#15014) [`a178422`](withastro/astro@a178422) Thanks [@&#8203;delucis](https://github.com/delucis)! - Adds support for extending the type of the props accepted by Astro’s `<Image>` component, `<Picture>` component, and `getImage()` API.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi41Mi44IiwidXBkYXRlZEluVmVyIjoiNDIuNTIuOCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

svgs not displaying correctly with passthroughImageService

3 participants