-
-
Notifications
You must be signed in to change notification settings - Fork 3k
feat: plugin hook filters (part 1) #14995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
| 📦 Package | 🔒 Before | 🔓 After |
|---|---|---|
| @cloudflare/unenv-preset | trusted-with-provenance | none |
| workerd | trusted-with-provenance | none |
| undici | provenance | none |
| miniflare | trusted-with-provenance | none |
| youch | provenance | none |
| @cloudflare/workerd-darwin-64 | trusted-with-provenance | none |
| @cloudflare/workerd-darwin-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-windows-64 | trusted-with-provenance | none |
| wrangler | trusted-with-provenance | none |
|
@florian-lefebvre I hate to ask this of you, but it's really difficult to review this given how many formatting changes there are. Could you submit another PR that formats and then rebase/merge this branch so that the diff is reduced to the relevant filter changes? Thanks! |
|
Yeah I understand! I'll wait for #14956 to be merged first to avoid you too many merge conflicts there |
|
@matthewp formatted! The diff remains pretty big unfortunately. The good thing tho is that you can basically check file by file and they usually do not rely on stuff in other files so it's pretty straight forward |
|
@florian-lefebvre my understanding was that you were going to submit a different PR with just |
|
This is what I've done but it didn't make a huge difference |
|
Ok, I trust you on this, giving it a quick look everything looks ok to me. |
* transform * wip * fix: regexes * fix: import.meta.env * fix: add .astro check * fix: error overlay regex * chore: format * fix * fix: css hmr
Changes
vite-plugin-config-aliasloadhook ran twice as less in my test)resolveIdandloadhooks. I didn't want to includetransformto avoid making it more complicated than it already is. There will be another PR for it entirely (feat: plugin hook filters (part 2) #15000)Testing
Should pass
Docs
N/A, internal refactor