Add more optimizeDeps for Cloudflare prebundling #15026
Conversation
Cloudflare does some prebundling, and Astro entrypoints (like astro/runtime and astro/app are prebundled. We need to exclude the virtual modules which can't be prebundled by esbuild. This is based on a demo app that failed without this config.
🦋 Changeset detectedLatest commit: 5a7bf49 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
|
| 📦 Package | 🔒 Before | 🔓 After |
|---|---|---|
| @cloudflare/unenv-preset | trusted-with-provenance | none |
| workerd | trusted-with-provenance | none |
| undici | provenance | none |
| miniflare | trusted-with-provenance | none |
| youch | provenance | none |
| @cloudflare/workerd-darwin-64 | trusted-with-provenance | none |
| @cloudflare/workerd-darwin-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-windows-64 | trusted-with-provenance | none |
| wrangler | trusted-with-provenance | none |
| 'unstorage/drivers/cloudflare-kv-binding', | ||
| 'astro:toolbar:internal', | ||
| 'virtual:astro:middleware', | ||
| 'virtual:astro:dev-css-all', |
There was a problem hiding this comment.
Does this support regexes? If so we could exclude all imports that start with virtual:
There was a problem hiding this comment.
It supports tinyglob patterns so maybe. I'll try this.
There was a problem hiding this comment.
Glob works, thanks for the idea!
|
I'm still seeing an issue with the build in my test project, going to hold off on merging until I solve that. |
matthewp
added
the
pr preview
|
Ah, that was because my local changes were wiped out, it's working now. |
Co-authored-by: Florian Lefebvre <[email protected]>
Changes
Testing
This is based on a demo app that failed without this config.
Docs
N/A, bug fix