fix(cloudflare): experimental chromeDevtoolsWorkspace #15030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0c42b20 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
changed the title
github-actions
bot
added
pkg: integration
Contributor
|
| 📦 Package | 🔒 Before | 🔓 After |
|---|---|---|
| @cloudflare/unenv-preset | trusted-with-provenance | none |
| workerd | trusted-with-provenance | none |
| undici | provenance | none |
| miniflare | trusted-with-provenance | none |
| youch | provenance | none |
| @cloudflare/workerd-darwin-64 | trusted-with-provenance | none |
| @cloudflare/workerd-darwin-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-windows-64 | trusted-with-provenance | none |
| wrangler | trusted-with-provenance | none |
matthewp
reviewed
Dec 16, 2025
ematipico
force-pushed
the
refactor/reduce-code-duplication
branch
from
df4e97e to
0c42b20
Compare
matthewp
approved these changes
Dec 16, 2025
Member
Member
Author
|
Cheers, moved it to done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
experimental.chromeDevtoolsWorkspacewasn't supported anymore by the Cloudflare adapter because the handling was done inside the astro dev server code path. I fixed it by moving the implementation inside a vite plugin, which is added tocreateVite.createViteand again in the astro server vite plugin. Now we have only one instance. I removed the use ofopts.ssrbecause we already useapplyToEnvironmentAstroServerAppDevAppinsideAstroServerApp. This is part of removingAstroServerAppfrom the codebaseTesting
Manually tested the cloudflare fixture. Manually tested
examples/blog.CI should stay green
Docs
N/A