Skip to content

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Jan 6, 2026

Changes

Testing

Manually in examples, should pass

Docs

Changeset + jsdoc

@florian-lefebvre florian-lefebvre self-assigned this Jan 6, 2026
@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2026

🦋 Changeset detected

Latest commit: 3f74cfa

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Jan 6, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 6, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing feat/deduplicate-context-types (3f74cfa) with main (b1e8e32)

Summary

✅ 6 untouched benchmarks

@ArmandPhilippot
Copy link
Member

ArmandPhilippot commented Jan 6, 2026

Sorry for the diff, not really easy to read... To summarize the commits I pushed, this:

  • fixes the links to Astro Docs: most of the section has been renamed (this might be a good idea to check the other files exposing public APIs... I can add that to my TODO list)
  • fixes props and params descriptions (not only static builds, and params was describing props)
  • replaces a few things for consistency. Doing a search in the code base to check what is most commonly used:
    • "Example usage:" > ## Example
    • Reference > Astro reference as anchor for links
  • rewords some descriptions to match what we have in the docs (not a full copy/paste, I only took inspiration from the docs) and add some examples to improve consistency between properties

For my last commit, in addition to having taken some wording from the docs, I was inspired by packages/astro/src/virtual-modules/i18n.ts that I recently updated. Hence the additional @params/@returns. I wasn't sure where to add them... they are not always in the same place in the file I linked... Maybe I should have done that in a separate commit if this is unwanted. 😅

I wasn't sure what you expected exactly regarding the structure. So, feel free to ask me additional changes, to revert some changes that might be too much, or to update my changes directly!

@florian-lefebvre
Copy link
Member Author

Perfect thank you!

@florian-lefebvre florian-lefebvre marked this pull request as ready for review January 7, 2026 08:27
@florian-lefebvre florian-lefebvre mentioned this pull request Jan 7, 2026
20 tasks
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff is a lot but as far as I can tell this looks great

@florian-lefebvre florian-lefebvre merged commit b137946 into main Jan 7, 2026
26 of 27 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/deduplicate-context-types branch January 7, 2026 09:20
@astrobot-houston astrobot-houston mentioned this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs pr pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants