Skip to content

fix(dev): preserve query params when base path is stripped #15124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
florian-lefebvre merged 8 commits into from
Jan 8, 2026
Merged

fix(dev): preserve query params when base path is stripped #15124

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e55ca03
fix(dev): preserve query params when base path is stripped
eureka928 Jan 7, 2026
54a57ea
chore: add changeset
eureka928 Jan 7, 2026
b40884c
fix: remove unnecessary code
eureka928 Jan 7, 2026
2f0d98c
fix: update request for config base check
eureka928 Jan 8, 2026
052b560
Update .changeset/bumpy-cats-sneeze.md
eureka928 Jan 8, 2026
aecd817
fix: simplify the base.ts changes with config.base || '/'
eureka928 Jan 8, 2026
d8aa966
Update .changeset/bumpy-cats-sneeze.md
eureka928 Jan 8, 2026
9926b6b
Update packages/astro/src/vite-plugin-astro-server/base.ts
eureka928 Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update .changeset/bumpy-cats-sneeze.md 
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
  • Loading branch information
@eureka928 @florian-lefebvre
eureka928 and florian-lefebvre authored Jan 8, 2026
commit d8aa966f56656f9a1243b93ff87cc47aae4f1538
2 changes: 1 addition & 1 deletion .changeset/bumpy-cats-sneeze.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
'astro': patch
---

Fixes an issue where requests with query parameters to the `base` path would return a 404 if trailingSlash was not 'ignore' in development
Fixes an issue where requests with query parameters to the `base` path would return a 404 if trailingSlash was not `'ignore'` in development
Loading