Skip to content

Support custom vue compiler options in @astrojs/vue#3143

Merged
tony-sull merged 4 commits intomainfrom
feat/vue-integration-options
Apr 19, 2022
Merged

Support custom vue compiler options in @astrojs/vue#3143
tony-sull merged 4 commits intomainfrom
feat/vue-integration-options

Conversation

@tony-sull
Copy link
Contributor

Changes

This updates the the Vue integration to support passing options through to @vitejs/plugin-vue

Testing

Updated the vue-component test with a custom element + Vue config to ignore component resolution for that tag

Docs

Updated the integration README

@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2022

🦋 Changeset detected

Latest commit: dfaddf6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) test labels Apr 19, 2022
@tony-sull tony-sull changed the title Support custom vue compiler options in @astrojs/vue` Support custom vue compiler options in @astrojs/vue Apr 19, 2022
@FredKSchott
Copy link
Member

Can I just say that I'm SO EXCITED that we can support this now?

... can you do Svelte next :) It would be great to match this API: https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/config.md

@FredKSchott
Copy link
Member

FredKSchott commented Apr 19, 2022

Also curious how much of this we should support as well: https://www.npmjs.com/package/@vitejs/plugin-vue

Edit: Oh wait, we literally support all of it, fantastic :)

@tony-sull tony-sull merged commit 44e294c into main Apr 19, 2022
@tony-sull tony-sull deleted the feat/vue-integration-options branch April 19, 2022 16:31
@github-actions github-actions bot mentioned this pull request Apr 19, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* adds support for passing options to @vitejs/plugin-vue

* updating vue integration README with options details

* adding a tests for custom vue compiler options

* chore: adding changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: vue Related to Vue (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants