Skip to content

Prevent removal of nested slots within islands#7093

Merged
matthewp merged 3 commits intomainfrom
remove-static-slots
May 17, 2023
Merged

Prevent removal of nested slots within islands#7093
matthewp merged 3 commits intomainfrom
remove-static-slots

Conversation

@matthewp
Copy link
Contributor

Changes

Testing

  • Used existing nested slot tests, but expanded and tested every affected framework:
    • React
    • Vue
    • Preact
    • Solid
    • Svelte

Docs

N/A, bug fix

@matthewp matthewp requested a review from a team as a code owner May 15, 2023 16:37
@changeset-bot
Copy link

changeset-bot bot commented May 15, 2023

🦋 Changeset detected

Latest commit: ef1d4da

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) semver: minor Change triggers a `minor` release labels May 15, 2023
@github-actions
Copy link
Contributor

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

Copy link
Member

@MoustaphaDev MoustaphaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking as this is a minor

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. It looks like #6301 and #6263 are kinda similar issues, but I don't think this PR fixes it.

@sarah11918 sarah11918 removed the request for review from a team May 16, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) semver: minor Change triggers a `minor` release

Projects

None yet

3 participants