Prevent removal of nested slots within islands#7093
Merged
Conversation
🦋 Changeset detectedLatest commit: ef1d4da The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR is blocked because it contains a |
MoustaphaDev
previously requested changes
May 15, 2023
Member
MoustaphaDev
left a comment
There was a problem hiding this comment.
Blocking as this is a minor
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
astro-static-slotinstead ofastro-slotwhen the slots are purely SSR. Doing this ensures that we only remove slots from SSR-only components and not from islands.supportsAstroStaticSlotflag. Otherwise we preserve the old behavior.<slot />in Vue component not rendering when hydrated #6669Testing
Docs
N/A, bug fix