-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[next]: stabilize failOnPrerenderConflict #12745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[next]: stabilize failOnPrerenderConflict #12745
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
@Fryuni I know you're busy so no rush! I'd like to know if that's what you had in mind, eg. if this option is in the right place |
| Using `'where'` gives you more control over specificity, but requires that you use higher-specificity selectors, layers, and other tools to control which selectors are applied. | ||
| Using `'attribute'` is useful when you are manipulating the `class` attribute of elements and need to avoid conflicts between your own styling logic and Astro's application of styles. | ||
|
|
||
| ### prerenderConflictBehavior |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@florian-lefebvre I added a placeholder here manually. This will be overwritten by whatever ends up being merged as JSDoc, but it's good enough for now!
NOTE: This is a "top-level" config option, so it needs to be somewhere roughly in this section of docs (not at the end) -- I'm commenting to that effect in the other PR!
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Description (required)
Related issues & labels (optional)
For Astro version:
6.0. See astro PR #14826.