Skip to content

Improve type checking job #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 7, 2024
Merged

Improve type checking job #1831

merged 6 commits into from
May 7, 2024

Conversation

@HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented May 6, 2024 •
edited
Loading

This PR is a follow-up to #1827 as I forgot that astro check checks all the files from a TypeScript project and not just Astro ones. The changes switch from tsc to astro check in the type checking job:

  • We get the same type checking as before plus Astro files
  • We no longer need to exclude components.ts so we can entirely remove the tsconfig.typecheck.json file

This PR also fixes issues reported by astro check in the Astro files and also addresses the warnings emitted so that we have a clean type checking job:

  • The EC related change is just replacing a deprecated import by its new one (reference)
  • Regarding the Tailwind test related one, did not even know TS emitted something for this (and this cannot be disabled) but I guess, meh, doesn't hurt and at least the output is clear…

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9b807db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview May 7, 2024 7:42am

@github-actions github-actions bot added 🌟 core Changes to Starlight’s main package 🌟 tailwind Changes to Starlight’s Tailwind package labels May 6, 2024
delucis
delucis approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @HiDeoo! Thank you. Have one query, but looks good.

@HiDeoo HiDeoo merged commit dc2be71 into withastro:main May 7, 2024
@HiDeoo HiDeoo deleted the hd-astro-check-action branch May 7, 2024 07:44
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request May 8, 2024
@HiDeoo
Merge branch 'main' into hd-refactor-astro-i18n
c193d55 
* main:
  i18n(zh-cn): Update docs about synced-tabs (withastro#1834)
  i18n(zh-cn): Update some docs about withastro#1620 & withastro#1613 (withastro#1835)
  Add more diagnostic help to error messages thrown by `<Steps>` (withastro#1838)
  i18n(zh-cn): Update components.mdx (withastro#1836)
  i18n(zh-cn): Update community-content.mdx (withastro#1833)
  Improve type checking job (withastro#1831)
  [ci] format
  [ci] release (withastro#1832)
  i18n(ru): update ru.json (withastro#1826)
  Fix `<Tabs>` sync issue with inconsistent use of `icon` on `<TabItem>` components (withastro#1811)
  Enable `BASE_URL` tests (withastro#1828)
Yoxnear pushed a commit to Yoxnear/starlight-custom that referenced this pull request Jul 23, 2025
@HiDeoo
Improve type checking job (withastro#1831)
27239f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

Assignees

No one assigned

Labels

🌟 core Changes to Starlight’s main package 🌟 tailwind Changes to Starlight’s Tailwind package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HiDeoo @delucis