Skip to content

Conversation

@trueberryless
Copy link
Contributor

Description

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2025

⚠️ No Changeset found

Latest commit: 8536bdc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 15, 2025
@netlify
Copy link

netlify bot commented Feb 15, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 87cdb22
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67b123062b7f3900085ac7ac
😎 Deploy Preview https://deploy-preview-2878--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Feb 15, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
de guides/overriding-components.mdx Localization changed, will be marked as complete.
de guides/route-data.mdx Localization added, will be marked as complete.
de guides/sidebar.mdx Localization changed, will be marked as complete.
de reference/overrides.md Localization changed, will be marked as complete.
de reference/plugins.md Localization changed, will be marked as complete.
de reference/route-data.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@trueberryless
Copy link
Contributor Author

trueberryless commented Feb 15, 2025

I think we need to merge so that the file reference/plugins.md is ignored (because this file also contains changes in the other PR merged today)

This should be contained in the commit message:

@lunaria-ignore:docs/src/content/docs/de/reference/plugins.md;src/content/docs/de/reference/plugins.md

(not necessary if this PR is merged as second -> probably some merge conflicts to solve then...)

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das war doch schnell! Ich habe nur ein Paar Fragezeichen hinterlassen aber allgemein sieht es super aus 🙌

@trueberryless
Copy link
Contributor Author

Super, dankeschön!

Tatsache ist, ich war schon so hyped auf den PR, dass ich die Übersetzungen bereits während WIP Phase gemacht hab und jeden Commit angeschaut hab, obs docs Änderungen gibt...

Kann ich im Nachhinein nicht empfehlen, aber war schon cool auch immer die neusten Changes ansehen zu müssen, damit die Translation passt... xD

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das nenne ich Begeisterung! 😁

Danke für die Verbesserungen 🎉

@delucis delucis merged commit 4ca7bd2 into withastro:main Feb 15, 2025
15 checks passed
@trueberryless trueberryless deleted the route-data-locals-de-translation branch February 16, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants