Skip to content

Conversation

@voidxno
Copy link

@voidxno voidxno commented Apr 6, 2025

PR adding home icon and Homepage social

Reason:

  • Need it myself. Have observed the other PR's around extra icon collections (very good). Independent of that, think a 'home' icon should be in standard Starlight collection.

Sample:

Created/drawn from scratch by me (screenshot below). Give all rights to Starlight, unconditionally. Basically used existing standard Starlight icons style as template. Baseline, alignment, size logic, thickness, curves, so on:

  • Drawn in Corel Designer, exported SVG (24x24), tuned/optimized SVG (svgo).

PS: Sorry if I have missed elements that should be in PR. Please point me in correct direction, will fix.

@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2025

⚠️ No Changeset found

Latest commit: 20b49cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Apr 6, 2025
@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@netlify
Copy link

netlify bot commented Apr 6, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 20b49cf
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67f27fb24ccf9300089f75d6
😎 Deploy Preview https://deploy-preview-3039--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@voidxno voidxno changed the title PR adding home icon and Homepage social Add home icon and Homepage social Apr 6, 2025
@delucis
Copy link
Member

delucis commented Apr 7, 2025

Thanks for your PR @voidxno! I think we won’t accept this PR in this form for a couple of reasons although I appreciate this nonetheless and you taking the time to draw the icon.

We are currently in the process of making Starlight’s icon and social link configuration more flexible and I think that work would already unlock what you want to do. Relevant PRs:

We also so far have always used icons from the open source Unicons icon set when adding generic icons, so for consistency if adding a built-in “home” icon, we would probably do the same to ensure the design matches between different icons.

In the meantime, I’d recommend using a component override to do this. There’s an example of exactly your use case with a custom SVG here in this thread: #3014 (comment)

@delucis delucis closed this Apr 7, 2025
@voidxno voidxno deleted the add_homeicon branch April 7, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌟 core Changes to Starlight’s main package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants