-
-
Notifications
You must be signed in to change notification settings - Fork 832
Relax remark/rehype plugins usage #3332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
HiDeoo
wants to merge
11
commits into
withastro:main
Choose a base branch
from
HiDeoo:hd-remark-rehype-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
62bde68
refactor: remark/rehype orchestration
HiDeoo 49a172e
feat: `markdown.processedDirs`
HiDeoo bac2f3b
docs: `markdown.processedDirs` documentation
HiDeoo 7335abf
Merge branch 'main' into hd-remark-rehype-refactor
HiDeoo ac9da15
fix: various lint issues
HiDeoo 712d1f9
Merge branch 'main' into hd-remark-rehype-refactor
HiDeoo bb39029
chore: fix comment missing word
HiDeoo 230cd5a
docs: improve wording
HiDeoo e39d23f
chore: add test fixture comment
HiDeoo 763c8d9
chore: reword config jsdoc to avoid being outdated
HiDeoo f484b10
chore: add changeset
HiDeoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
packages/starlight/__e2e__/fixtures/basics/src/content/comments/bob.mdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| --- | ||
| title: Comment from Bob | ||
| --- | ||
|
|
||
| # Comment from Bob | ||
|
|
||
| This is a comment from Bob. | ||
|
|
||
| ## Description | ||
|
|
||
| This content collection entry is not part of the Starlight `docs` collection. | ||
| It is used to test that various remark/rehype plugins are transforming non-docs collection entries matching the `markdown.processedDirs` option. | ||
|
|
||
| :::note | ||
| This is a note using Starlight Markdown aside syntax. | ||
| ::: | ||
|
|
||
| This is an `inline code` example. |
21 changes: 21 additions & 0 deletions
21
packages/starlight/__e2e__/fixtures/basics/src/pages/comments/[...comment].astro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| --- | ||
| import { getEntry, render } from 'astro:content'; | ||
|
|
||
| /** | ||
| * This route is used to test that remark/rehype plugins are transofming non-docs collection | ||
| * entries matching the `markdown.processedDirs` option. | ||
| */ | ||
|
|
||
| export function getStaticPaths() { | ||
| return [{ params: { comment: 'bob' } }]; | ||
| } | ||
|
|
||
| // @ts-expect-error - we don't generate types for this test fixture before type-checking the entire | ||
| // project. | ||
| const entry = await getEntry('comments', 'bob'); | ||
| if (!entry) throw new Error('Could not find Bob review entry.'); | ||
|
|
||
| const { Content } = await render(entry); | ||
| --- | ||
|
|
||
| <Content /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.