Skip to content

Basic support for Jest runner #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rotemmiz merged 20 commits into from
Oct 17, 2017
Merged

Basic support for Jest runner #335

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
d5d93cc
Add basic jest runner support
Oct 11, 2017
ba08fba
Adjust Jest documentation
Oct 11, 2017
8bf5abd
Add missing --runInBand flag to jest command
Oct 11, 2017
bcb0174
Use process.env instead of process.argv (not supported in Jest)
Oct 13, 2017
9157bb0
Merge branch 'master' into feature/support-jest-runner
Kureev Oct 13, 2017
efe3b39
Adjust tests to the new env approach
Oct 13, 2017
c3c0077
Adjust indentation in package.json
Oct 13, 2017
92a1c49
Add process.env to child process
Kureev Oct 14, 2017
14d6965
Support runner option in detox config
Kureev Oct 15, 2017
256af2b
Update Guide.Jest to document a new way of changing runner
Kureev Oct 15, 2017
afcfc0e
Revert mocha.opts change (not a part of the scope)
Kureev Oct 15, 2017
8fde423
Revert formatting changes (not a part of the scope)
Kureev Oct 15, 2017
8c9dc3b
Use alternative flow to handle env variables
Oct 16, 2017
8092625
Support argv and priorotize them over env vars
Oct 16, 2017
dc45bc2
Cleanup detox-test.js
Kureev Oct 16, 2017
63b4519
Setup debug-synchronization value
Kureev Oct 16, 2017
35e0f65
Fix runner problem
Kureev Oct 17, 2017
3803b47
Reset example.xcodeproj
Kureev Oct 17, 2017
21690b8
Merge branch 'master' into feature/support-jest-runner
Kureev Oct 17, 2017
5fcfa4a
Remove constant override
Kureev Oct 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Setup debug-synchronization value
  • Loading branch information
@Kureev
Kureev committed Oct 16, 2017
commit 63b45194a3bfb305467b79f47e537a3d92e6e148
8 changes: 7 additions & 1 deletion detox/local-cli/detox-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ function runMocha() {
const cleanup = program.cleanup ? `--cleanup` : '';
const reuse = program.reuse ? `--reuse` : '';
const artifactsLocation = program.artifactsLocation ? `--artifacts-location ${program.artifactsLocation}` : '';

if (typeof program.debugSynchronization === "boolean") {
program.debugSynchronization = 3000;
}

const debugSynchronization = program.debugSynchronization ? `--debug-synchronization ${program.debugSynchronization}` : '';
const command = `node_modules/.bin/${program.runner} ${testFolder} --opts ${testFolder}/${program.runnerConfig} ${configuration} ${loglevel} ${cleanup} ${reuse} ${debugSynchronization} ${artifactsLocation}`;

console.log(command);
Expand All @@ -50,7 +56,7 @@ function runJest() {
loglevel: program.loglevel,
cleanup: program.cleanup,
reuse: program.reuse,
debugSynchronization: program.debugSynchronization,
debugSynchronization: program.debugSynchronization ? 3000 : '',
Copy link
Contributor

@rotemmiz rotemmiz Oct 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kureev , wouldn't this override every number value with 3000 ?

Copy link
Contributor Author

@Kureev Kureev Oct 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rotemmiz! Nice catch, fixed! 😉

artifactsLocation: program.artifactsLocation
}
});
Expand Down