Skip to content

Commit 7ee21db

Browse files
committed
ci-operator/jobs/openshift/cluster-version-operator: Move 4.4 and later presubmits to GCP
AWS is currently at CI-capacity limits, so move over to GCP to get more elbow room. Generated by adjusting the config/ entry by hand and then running: $ make update I'd initially just shifted master, because the bulk of our CI is on master-targeted pulls. But Scott asked for 4.4 and later [1], so that's what I'm doing now. I'd like to move to generic names like "e2e" and "e2e-upgrade", because we don't care (from the CVO side) what platform these run on. Generic names will mean smaller diffs if we pivot the workflow and cluster_profile to a different provider in the future. But Scott is not (yet ;) ready to break with tradition here [2], so punting on that for now. I've dropped "e2e-aws-upi", because the CVO shouldn't care about that level of provisioning detail. We just need "a cluster". We've had the optional UPI job since ce9361b (cluster-version-operator: add aws-upi optional job, 2020-02-11, openshift#7125), where it was motivated [3] by a desire to test the cluster_installer metric [4]. Now that that metric is well-established, we can drop the option. And we can always regrow it if we need it again later. [1]: openshift#10046 (comment) [2]: openshift#10046 (comment) [3]: openshift#7125 (comment) [4]: openshift/cluster-version-operator#319
1 parent 25d84ee commit 7ee21db

10 files changed

+125
-513
lines changed

ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-master.yaml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,19 +27,15 @@ tests:
2727
commands: go test ./...
2828
container:
2929
from: src
30-
- as: e2e-aws
30+
- as: e2e-gcp
3131
steps:
32-
cluster_profile: aws
33-
workflow: openshift-e2e-aws
34-
- as: e2e-aws-upgrade
32+
cluster_profile: gcp
33+
workflow: openshift-e2e-gcp
34+
- as: e2e-gcp-upgrade
3535
commands: TEST_SUITE=all TEST_OPTIONS=abort-at=100 run-upgrade-tests
3636
openshift_installer:
37-
cluster_profile: aws
37+
cluster_profile: gcp
3838
upgrade: true
39-
- as: e2e-aws-upi
40-
commands: TEST_SUITE=openshift/conformance/parallel run-tests
41-
openshift_installer_upi:
42-
cluster_profile: aws
4339
zz_generated_metadata:
4440
branch: master
4541
org: openshift

ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-release-4.4.yaml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,19 +27,15 @@ tests:
2727
commands: go test ./...
2828
container:
2929
from: src
30-
- as: e2e-aws
30+
- as: e2e-gcp
3131
steps:
32-
cluster_profile: aws
33-
workflow: openshift-e2e-aws
34-
- as: e2e-aws-upgrade
32+
cluster_profile: gcp
33+
workflow: openshift-e2e-gcp
34+
- as: e2e-gcp-upgrade
3535
commands: TEST_SUITE=all TEST_OPTIONS=abort-at=100 run-upgrade-tests
3636
openshift_installer:
37-
cluster_profile: aws
37+
cluster_profile: gcp
3838
upgrade: true
39-
- as: e2e-aws-upi
40-
commands: TEST_SUITE=openshift/conformance/parallel run-tests
41-
openshift_installer_upi:
42-
cluster_profile: aws
4339
zz_generated_metadata:
4440
branch: release-4.4
4541
org: openshift

ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-release-4.5.yaml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,19 +27,15 @@ tests:
2727
commands: go test ./...
2828
container:
2929
from: src
30-
- as: e2e-aws
30+
- as: e2e-gcp
3131
steps:
32-
cluster_profile: aws
33-
workflow: openshift-e2e-aws
34-
- as: e2e-aws-upgrade
32+
cluster_profile: gcp
33+
workflow: openshift-e2e-gcp
34+
- as: e2e-gcp-upgrade
3535
commands: TEST_SUITE=all TEST_OPTIONS=abort-at=100 run-upgrade-tests
3636
openshift_installer:
37-
cluster_profile: aws
37+
cluster_profile: gcp
3838
upgrade: true
39-
- as: e2e-aws-upi
40-
commands: TEST_SUITE=openshift/conformance/parallel run-tests
41-
openshift_installer_upi:
42-
cluster_profile: aws
4339
zz_generated_metadata:
4440
branch: release-4.5
4541
org: openshift

ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-release-4.6.yaml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,15 @@ tests:
2828
commands: go test ./...
2929
container:
3030
from: src
31-
- as: e2e-aws
31+
- as: e2e-gcp
3232
steps:
33-
cluster_profile: aws
34-
workflow: openshift-e2e-aws
35-
- as: e2e-aws-upgrade
33+
cluster_profile: gcp
34+
workflow: openshift-e2e-gcp
35+
- as: e2e-gcp-upgrade
3636
commands: TEST_SUITE=all TEST_OPTIONS=abort-at=100 run-upgrade-tests
3737
openshift_installer:
38-
cluster_profile: aws
38+
cluster_profile: gcp
3939
upgrade: true
40-
- as: e2e-aws-upi
41-
commands: TEST_SUITE=openshift/conformance/parallel run-tests
42-
openshift_installer_upi:
43-
cluster_profile: aws
4440
zz_generated_metadata:
4541
branch: release-4.6
4642
org: openshift

ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-release-4.7.yaml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,19 +27,15 @@ tests:
2727
commands: go test ./...
2828
container:
2929
from: src
30-
- as: e2e-aws
30+
- as: e2e-gcp
3131
steps:
32-
cluster_profile: aws
33-
workflow: openshift-e2e-aws
34-
- as: e2e-aws-upgrade
32+
cluster_profile: gcp
33+
workflow: openshift-e2e-gcp
34+
- as: e2e-gcp-upgrade
3535
commands: TEST_SUITE=all TEST_OPTIONS=abort-at=100 run-upgrade-tests
3636
openshift_installer:
37-
cluster_profile: aws
37+
cluster_profile: gcp
3838
upgrade: true
39-
- as: e2e-aws-upi
40-
commands: TEST_SUITE=openshift/conformance/parallel run-tests
41-
openshift_installer_upi:
42-
cluster_profile: aws
4339
zz_generated_metadata:
4440
branch: release-4.7
4541
org: openshift

ci-operator/jobs/openshift/cluster-version-operator/openshift-cluster-version-operator-master-presubmits.yaml

Lines changed: 20 additions & 94 deletions
Original file line numberDiff line numberDiff line change
@@ -5,24 +5,24 @@ presubmits:
55
branches:
66
- master
77
cluster: api.ci
8-
context: ci/prow/e2e-aws
8+
context: ci/prow/e2e-gcp
99
decorate: true
1010
decoration_config:
1111
skip_cloning: true
1212
labels:
1313
ci-operator.openshift.io/prowgen-controlled: "true"
1414
pj-rehearse.openshift.io/can-be-rehearsed: "true"
15-
name: pull-ci-openshift-cluster-version-operator-master-e2e-aws
16-
rerun_command: /test e2e-aws
15+
name: pull-ci-openshift-cluster-version-operator-master-e2e-gcp
16+
rerun_command: /test e2e-gcp
1717
spec:
1818
containers:
1919
- args:
2020
- --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson
2121
- --lease-server-password-file=/etc/boskos/password
2222
- --report-password-file=/etc/report/password.txt
2323
- --report-username=ci
24-
- --secret-dir=/usr/local/e2e-aws-cluster-profile
25-
- --target=e2e-aws
24+
- --secret-dir=/usr/local/e2e-gcp-cluster-profile
25+
- --target=e2e-gcp
2626
command:
2727
- ci-operator
2828
image: ci-operator:latest
@@ -35,7 +35,7 @@ presubmits:
3535
- mountPath: /etc/boskos
3636
name: boskos
3737
readOnly: true
38-
- mountPath: /usr/local/e2e-aws-cluster-profile
38+
- mountPath: /usr/local/e2e-gcp-cluster-profile
3939
name: cluster-profile
4040
- mountPath: /etc/pull-secret
4141
name: pull-secret
@@ -55,37 +55,39 @@ presubmits:
5555
projected:
5656
sources:
5757
- secret:
58-
name: cluster-secrets-aws
58+
name: cluster-secrets-gcp
59+
- configMap:
60+
name: cluster-profile-gcp
5961
- name: pull-secret
6062
secret:
6163
secretName: regcred
6264
- name: result-aggregator
6365
secret:
6466
secretName: result-aggregator
65-
trigger: (?m)^/test( | .* )e2e-aws,?($|\s.*)
67+
trigger: (?m)^/test( | .* )e2e-gcp,?($|\s.*)
6668
- agent: kubernetes
6769
always_run: true
6870
branches:
6971
- master
7072
cluster: api.ci
71-
context: ci/prow/e2e-aws-upgrade
73+
context: ci/prow/e2e-gcp-upgrade
7274
decorate: true
7375
decoration_config:
7476
skip_cloning: true
7577
labels:
7678
ci-operator.openshift.io/prowgen-controlled: "true"
7779
pj-rehearse.openshift.io/can-be-rehearsed: "true"
78-
name: pull-ci-openshift-cluster-version-operator-master-e2e-aws-upgrade
79-
rerun_command: /test e2e-aws-upgrade
80+
name: pull-ci-openshift-cluster-version-operator-master-e2e-gcp-upgrade
81+
rerun_command: /test e2e-gcp-upgrade
8082
spec:
8183
containers:
8284
- args:
8385
- --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson
8486
- --lease-server-password-file=/etc/boskos/password
8587
- --report-password-file=/etc/report/password.txt
8688
- --report-username=ci
87-
- --secret-dir=/usr/local/e2e-aws-upgrade-cluster-profile
88-
- --target=e2e-aws-upgrade
89+
- --secret-dir=/usr/local/e2e-gcp-upgrade-cluster-profile
90+
- --target=e2e-gcp-upgrade
8991
command:
9092
- ci-operator
9193
image: ci-operator:latest
@@ -98,7 +100,7 @@ presubmits:
98100
- mountPath: /etc/boskos
99101
name: boskos
100102
readOnly: true
101-
- mountPath: /usr/local/e2e-aws-upgrade-cluster-profile
103+
- mountPath: /usr/local/e2e-gcp-upgrade-cluster-profile
102104
name: cluster-profile
103105
- mountPath: /etc/pull-secret
104106
name: pull-secret
@@ -118,92 +120,16 @@ presubmits:
118120
projected:
119121
sources:
120122
- secret:
121-
name: cluster-secrets-aws
123+
name: cluster-secrets-gcp
124+
- configMap:
125+
name: cluster-profile-gcp
122126
- name: pull-secret
123127
secret:
124128
secretName: regcred
125129
- name: result-aggregator
126130
secret:
127131
secretName: result-aggregator
128-
trigger: (?m)^/test( | .* )e2e-aws-upgrade,?($|\s.*)
129-
- agent: kubernetes
130-
always_run: false
131-
branches:
132-
- master
133-
cluster: api.ci
134-
context: ci/prow/e2e-aws-upi
135-
decorate: true
136-
decoration_config:
137-
skip_cloning: true
138-
labels:
139-
ci-operator.openshift.io/prowgen-controlled: "true"
140-
pj-rehearse.openshift.io/can-be-rehearsed: "true"
141-
name: pull-ci-openshift-cluster-version-operator-master-e2e-aws-upi
142-
optional: true
143-
rerun_command: /test e2e-aws-upi
144-
spec:
145-
containers:
146-
- args:
147-
- --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson
148-
- --lease-server-password-file=/etc/boskos/password
149-
- --report-password-file=/etc/report/password.txt
150-
- --report-username=ci
151-
- --secret-dir=/usr/local/e2e-aws-upi-cluster-profile
152-
- --target=e2e-aws-upi
153-
- --template=/usr/local/e2e-aws-upi
154-
command:
155-
- ci-operator
156-
env:
157-
- name: CLUSTER_TYPE
158-
value: aws
159-
- name: JOB_NAME_SAFE
160-
value: e2e-aws-upi
161-
- name: TEST_COMMAND
162-
value: TEST_SUITE=openshift/conformance/parallel run-tests
163-
image: ci-operator:latest
164-
imagePullPolicy: Always
165-
name: ""
166-
resources:
167-
requests:
168-
cpu: 10m
169-
volumeMounts:
170-
- mountPath: /etc/boskos
171-
name: boskos
172-
readOnly: true
173-
- mountPath: /usr/local/e2e-aws-upi-cluster-profile
174-
name: cluster-profile
175-
- mountPath: /usr/local/e2e-aws-upi
176-
name: job-definition
177-
subPath: cluster-launch-installer-upi-e2e.yaml
178-
- mountPath: /etc/pull-secret
179-
name: pull-secret
180-
readOnly: true
181-
- mountPath: /etc/report
182-
name: result-aggregator
183-
readOnly: true
184-
serviceAccountName: ci-operator
185-
volumes:
186-
- name: boskos
187-
secret:
188-
items:
189-
- key: password
190-
path: password
191-
secretName: boskos-credentials
192-
- name: cluster-profile
193-
projected:
194-
sources:
195-
- secret:
196-
name: cluster-secrets-aws
197-
- configMap:
198-
name: prow-job-cluster-launch-installer-upi-e2e
199-
name: job-definition
200-
- name: pull-secret
201-
secret:
202-
secretName: regcred
203-
- name: result-aggregator
204-
secret:
205-
secretName: result-aggregator
206-
trigger: (?m)^/test( | .* )e2e-aws-upi,?($|\s.*)
132+
trigger: (?m)^/test( | .* )e2e-gcp-upgrade,?($|\s.*)
207133
- agent: kubernetes
208134
always_run: true
209135
branches:

0 commit comments

Comments
 (0)