Skip to content

Conversation

@abhinavdahiya
Copy link
Contributor

@abhinavdahiya
Copy link
Contributor Author

/assign @crawford @wking

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 11, 2020
@crawford
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, crawford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit aab4de1 into openshift:master Feb 12, 2020
@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: Updated the following 4 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-cluster-version-operator-master.yaml using file ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-cluster-version-operator-master.yaml using file ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-cluster-version-operator-master.yaml using file ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-master.yaml
  • job-config-master configmap in namespace ci at cluster default using the following files:
    • key openshift-cluster-version-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-version-operator/openshift-cluster-version-operator-master-presubmits.yaml
Details

In response to this:

would help test the PR openshift/cluster-version-operator#319 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-version-operator/master/e2e-aws-upi ce9361b link /test pj-rehearse
ci/prow/pj-rehearse ce9361b link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

wking added a commit to wking/openshift-release that referenced this pull request Jul 7, 2020
…er presubmits to GCP

AWS is currently at CI-capacity limits, so move over to GCP to get
more elbow room.  Generated by adjusting the config/ entry by hand and
then running:

  $ make update

I'd initially just shifted master, because the bulk of our CI is on
master-targeted pulls.  But Scott asked for 4.4 and later [1], so
that's what I'm doing now.

I'd like to move to generic names like "e2e" and "e2e-upgrade",
because we don't care (from the CVO side) what platform these run on.
Generic names will mean smaller diffs if we pivot the workflow and
cluster_profile to a different provider in the future.  But Scott is
not (yet ;) ready to break with tradition here [2], so punting on that
for now.

I've dropped "e2e-aws-upi", because the CVO shouldn't care about that
level of provisioning detail.  We just need "a cluster".  We've had
the optional UPI job since ce9361b (cluster-version-operator: add
aws-upi optional job, 2020-02-11, openshift#7125), where it was motivated [3]
by a desire to test the cluster_installer metric [4].  Now that that
metric is well-established, we can drop the option.  And we can always
regrow it if we need it again later.

[1]: openshift#10046 (comment)
[2]: openshift#10046 (comment)
[3]: openshift#7125 (comment)
[4]: openshift/cluster-version-operator#319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants