-
Notifications
You must be signed in to change notification settings - Fork 2k
cluster-version-operator: add aws-upi optional job #7125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster-version-operator: add aws-upi optional job #7125
Conversation
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@abhinavdahiya: Updated the following 4 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@abhinavdahiya: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…er presubmits to GCP AWS is currently at CI-capacity limits, so move over to GCP to get more elbow room. Generated by adjusting the config/ entry by hand and then running: $ make update I'd initially just shifted master, because the bulk of our CI is on master-targeted pulls. But Scott asked for 4.4 and later [1], so that's what I'm doing now. I'd like to move to generic names like "e2e" and "e2e-upgrade", because we don't care (from the CVO side) what platform these run on. Generic names will mean smaller diffs if we pivot the workflow and cluster_profile to a different provider in the future. But Scott is not (yet ;) ready to break with tradition here [2], so punting on that for now. I've dropped "e2e-aws-upi", because the CVO shouldn't care about that level of provisioning detail. We just need "a cluster". We've had the optional UPI job since ce9361b (cluster-version-operator: add aws-upi optional job, 2020-02-11, openshift#7125), where it was motivated [3] by a desire to test the cluster_installer metric [4]. Now that that metric is well-established, we can drop the option. And we can always regrow it if we need it again later. [1]: openshift#10046 (comment) [2]: openshift#10046 (comment) [3]: openshift#7125 (comment) [4]: openshift/cluster-version-operator#319
would help test the PR openshift/cluster-version-operator#319 (comment)