This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Fix build issues for production builds #2042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/icons and @wordpress/primitives to be used directly.
nerrad
added
type: bug
Contributor
|
Size Change: +224 kB (9%) 🔍 Total Size: 2.25 MB
ℹ️ View Unchanged
|
It looks like when a style is imported on the entrypoint of a component (or in a file with just exports), it get’s treeshaken from the final build _regardless of exception rules_.
nerrad
requested review from
mikejolley and
senadir
and removed request for
a team and
mikejolley
senadir
approved these changes
Mar 27, 2020
Member
senadir
left a comment
senadir
left a comment
There was a problem hiding this comment.
so after a lot of testing, this PR is finally ready to merge, there was a lot of going back and forth in the team channel, this fixes several issues like the skeleton, missing dependencies, broken build and other things, great work here @nerrad
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed today that we're getting build issues for production builds with the current master checkout and cart blocks.
The issues are when you do a production build of the blocks. On a default WordPress install (latest version of WP, no GB plugin active):
The fix for both issues is to account for more
sideEffectexclusions. As a result, bundlesizes do jump, this is because the payment-methods demo files weren't being included in production builds, so now that they are included the size jumps.This will be handled in a followup where payment method integrations will be built to their own bundle (which is what will happen anyways when they are implemented in payment extensions).