Skip to content

Conversation

@ajavadinezhad
Copy link
Contributor

@ajavadinezhad ajavadinezhad commented Apr 5, 2019

hi
Please accept my request to add Persian Dictionary.
be soon the rest of the sections will be completed.
Thanks in advance

Copy link
Owner

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @AhmadJavadiNejad!

The main question I have is where the source of the dictionary comes from: did you write it yourself, or did you get the dictionary from somewhere else?
If the former, I have some other questions, but I suspect the latter, in which case, I can’t accept this PR because it does not reference where it comes from, and that’s probably a breach of contract / license.

@ajavadinezhad
Copy link
Contributor Author

Thanks for working on this, @AhmadJavadiNejad!

The main question I have is where the source of the dictionary comes from: did you write it yourself, or did you get the dictionary from somewhere else?
If the former, I have some other questions, but I suspect the latter, in which case, I can’t accept this PR because it does not reference where it comes from, and that’s probably a breach of contract / license.

Yes sure. in the next commit, I'll provide references for the dictionary.

@ajavadinezhad
Copy link
Contributor Author

Thanks for working on this, @AhmadJavadiNejad!

The main question I have is where the source of the dictionary comes from: did you write it yourself, or did you get the dictionary from somewhere else?
If the former, I have some other questions, but I suspect the latter, in which case, I can’t accept this PR because it does not reference where it comes from, and that’s probably a breach of contract / license.

hi
the license and vocabulary sources are specified.
thanks.

@wooorm
Copy link
Owner

wooorm commented May 3, 2019

Any reason why you’re not basing this off b00f/lilak? That looks better as it has a working .aff file.

@ajavadinezhad
Copy link
Contributor Author

Any reason why you’re not basing this off b00f/lilak? That looks better as it has a working .aff file.

There is no particular reason, so far I did not see this repository. I was also looking to Writing a .affx file.

wooorm added a commit that referenced this pull request May 5, 2019
Closes GH-10.

Co-authored-by: Ahmad Javadi Nejad <[email protected]>
@wooorm wooorm mentioned this pull request May 5, 2019
@wooorm wooorm closed this in #11 May 29, 2019
wooorm added a commit that referenced this pull request May 29, 2019
Closes GH-10.
Closes GH-11.

Co-authored-by: Ahmad Javadi Nejad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants