Safely parse color string #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis
added
bug
Gutenberg
geriux
approved these changes
Apr 23, 2024
geriux
left a comment
geriux
left a comment
There was a problem hiding this comment.
LGTM! I was able to reproduce by using:
<!-- wp:paragraph -->
<p><mark style="background-color:rgba(0,0,0,0);color:#000" class="has-inline-color has-black-color">Hey</mark></p>
<!-- /wp:paragraph -->With these changes the crash is fixed 🚀
13 tasks
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/WordPress-Android#20694 and wordpress-mobile/WordPress-Android#20698
Related PRs:
Fix
This PR adds exception handling for the
Color.parseColorfunction call to prevent the app from crashing. Similar handling is done in two other case in Aztec (one, two)Test
I was not able to reproduce the crash thus I suggest a sanity check of the functionality introduced in #1073
Make sure strings will be translated:
strings.xmlas a part of the integration PR.