Fix issues with block media at the end of editable text #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmandaRiu
approved these changes
Apr 7, 2022
Contributor
AmandaRiu
left a comment
AmandaRiu
left a comment
There was a problem hiding this comment.
Tested and works beautifully!
Also ran the new tests and all passed. Left a small low-priority code comment for your review @planarvoid . This PR is approved and is ready to merge when you are! 
|
|
||
| private fun insertSpanAfterBlock(ssb: SpannableStringBuilder) { | ||
| val position = getEndOfBlock() | ||
| var position = getEndOfBlock() |
Contributor
There was a problem hiding this comment.
np: this value is never modified so it can be changed back to val
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
There was an issue I discovered when I tried to add an image after the last block of the content. This is now fixed in this PR. I've added a lot of tests covering everything (and found a few minor issues during the process).
Test
aztec.visualEditor.addMediaAfterBlocks()Review
@AmandaRiu
Make sure strings will be translated:
strings.xmlas a part of the integration PR.