Skip to content

Allow configuration of default fonts used in TextView #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SergioEstevao merged 10 commits into from
Oct 9, 2019
Merged

Allow configuration of default fonts used in TextView #1221

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1f47ac8
Allow dynamic change of default font.
SergioEstevao Oct 7, 2019
efc0760
Remove unused code.
SergioEstevao Oct 8, 2019
cdb2814
Use font provider class to provide default fonts
SergioEstevao Oct 8, 2019
b155e7d
Make font properties public
SergioEstevao Oct 8, 2019
7f998f4
Improve and generalize code for replacement of fonts in attributed st…
SergioEstevao Oct 9, 2019
31e70a0
Make font provider shared instance public
SergioEstevao Oct 9, 2019
3d0c2e8
Improve replaceFont code and add some documentation.
SergioEstevao Oct 9, 2019
7eddd37
Fix possible issues were font is not available.
SergioEstevao Oct 9, 2019
46ac801
Add documentation.
SergioEstevao Oct 9, 2019
fa4c640
Fix test
SergioEstevao Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add documentation.
  • Loading branch information
@SergioEstevao
SergioEstevao committed Oct 9, 2019
commit 46ac801299efaa9abdcc6ea7c4080bdfa8c34130
8 changes: 7 additions & 1 deletion Aztec/Classes/TextKit/TextView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,8 @@ open class TextView: UITextView {

// MARK: - Properties: UI Defaults

/// The font to use to render any HTML that doesn't specify an explicit font.
/// If this is changed all the instances that use this font will be updated to the new one.
public var defaultFont: UIFont {
didSet {
textStorage.replace(font: oldValue, with: defaultFont)
Expand Down Expand Up @@ -359,6 +361,10 @@ open class TextView: UITextView {

// MARK: - Init & deinit

/// Creates a Text View using the provided parameters as a base for HTML rendering.
/// - Parameter defaultFont: The font to use to render the elements if no specific font is set by the HTML.
/// - Parameter defaultParagraphStyle: The default paragraph style if no explicit attributes are defined in HTML
/// - Parameter defaultMissingImage: The image to use if the view is not able to render an image specified in the HTML.
@objc public init(
defaultFont: UIFont,
defaultParagraphStyle: ParagraphStyle = ParagraphStyle.default,
Expand All @@ -385,7 +391,7 @@ open class TextView: UITextView {
}

required public init?(coder aDecoder: NSCoder) {
self.defaultFont = FontProvider.shared.defaultFont
defaultFont = FontProvider.shared.defaultFont
defaultParagraphStyle = ParagraphStyle.default
defaultMissingImage = Assets.imageIcon

Expand Down