Skip to content

Update project to have iOS 11 has a minimum #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SergioEstevao merged 5 commits into from
Oct 10, 2019
Merged

Update project to have iOS 11 has a minimum #1222

SergioEstevao merged 5 commits into from
Oct 10, 2019

Conversation

@SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Oct 9, 2019

This just updates the project to assume iOS 11 has a minimum.

To test:

  • Check if the project compiles correctly and unit tests are good.
  • Some test some of the demo content to see if all is ok.

@SergioEstevao SergioEstevao added this to the Next Stable milestone Oct 9, 2019
@SergioEstevao SergioEstevao requested a review from etoledom October 9, 2019 12:38
etoledom
etoledom approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thank you 🙏

@SergioEstevao SergioEstevao merged commit 81e1e1b into develop Oct 10, 2019
@SergioEstevao SergioEstevao deleted the issue/update_xcode_ios_version branch October 10, 2019 08:37
@etoledom etoledom mentioned this pull request Oct 14, 2019
Merged
@SergioEstevao SergioEstevao modified the milestones: Next Stable, 1.12.0 Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@etoledom etoledom etoledom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Enhancement

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@SergioEstevao @etoledom