-
Notifications
You must be signed in to change notification settings - Fork 3
build: Upgrade WordPress packages #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of these depend upon one another and must be upgraded together.
The `display: flex;` declaration was removed in core: WordPress/gutenberg#66706 Its removal causes the post title's margin to extend beyond its parent boundaries, which caused the background color to not render the entire height of the editor.
Rename classes to match component file names.
The latest version is incompatible with Gutenberg ESLint configuration.
This reverts commit 147de47.
Postpone ESLint upgrades due to various configuration conflicts.
This resolves a regression introduced from changes in the following PR. Ideally we resolve this issue in Gutenberg core, rather than overriding the styles within GutenbergKit. WordPress/gutenberg#66706
652fb6f to
50968ac
Compare
kean
approved these changes
Jan 29, 2025
If Apple and Google allowed programmatic focus of interactive elements in web views, this would ensure the post title field is focused for new drafts. However, Apple and Google require user interaction--e.g., taps--for the virtual keyboard to display. Regardless, denoting the auto-draft status is likely still worthwhile.
50968ac to
af3f3a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upgrade
@wordpresspackages to latest versions.Why?
Fixes #65. Include latest features and bug fixes. Namely, the following:
How?
Install the latest package versions. Address editor regressions from upstream
changes.
Testing Instructions
Accessibility Testing Instructions
N/A, no user-facing changes.
Screenshots or screencast
N/A, no user-facing changes.