Skip to content

Conversation

@dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jan 28, 2025

What?

Upgrade @wordpress packages to latest versions.

Why?

Fixes #65. Include latest features and bug fixes. Namely, the following:

How?

Install the latest package versions. Address editor regressions from upstream
changes.

Testing Instructions

Accessibility Testing Instructions

N/A, no user-facing changes.

Screenshots or screencast

N/A, no user-facing changes.

Most of these depend upon one another and must be upgraded together.
The `display: flex;` declaration was removed in core:

WordPress/gutenberg#66706

Its removal causes the post title's margin to extend beyond its parent
boundaries, which caused the background color to not render the entire
height of the editor.
Rename classes to match component file names.
@dcalhoun dcalhoun added the [Type] Enhancement A suggestion for improvement. label Jan 28, 2025
The latest version is incompatible with Gutenberg ESLint configuration.
Postpone ESLint upgrades due to various configuration conflicts.
This resolves a regression introduced from changes in the following PR.
Ideally we resolve this issue in Gutenberg core, rather than overriding
the styles within GutenbergKit.

WordPress/gutenberg#66706
@dcalhoun dcalhoun marked this pull request as ready for review January 29, 2025 14:38
@dcalhoun dcalhoun added [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Jan 29, 2025
@dcalhoun dcalhoun requested a review from kean January 29, 2025 14:38
@dcalhoun dcalhoun force-pushed the build/upgrade-dependencies branch from 652fb6f to 50968ac Compare January 29, 2025 17:05
If Apple and Google allowed programmatic focus of interactive elements
in web views, this would ensure the post title field is focused for new
drafts. However, Apple and Google require user interaction--e.g.,
taps--for the virtual keyboard to display.

Regardless, denoting the auto-draft status is likely still worthwhile.
@dcalhoun dcalhoun force-pushed the build/upgrade-dependencies branch from 50968ac to af3f3a9 Compare January 29, 2025 17:41
@dcalhoun dcalhoun enabled auto-merge (squash) January 29, 2025 17:42
@dcalhoun dcalhoun merged commit c050b4d into trunk Jan 29, 2025
8 of 9 checks passed
@dcalhoun dcalhoun deleted the build/upgrade-dependencies branch January 29, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block inserter includes un-insertable block types

3 participants