Fix media replacement on media-text block #10710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koke
force-pushed
the
issue/gb-1509-fix-media-text-upload-replacement
branch
from
44b4128 to
66b2e1b
Compare
|
You can test the changes on this Pull Request by downloading the APK here. |
koke
force-pushed
the
issue/gb-1509-fix-media-text-upload-replacement
branch
from
66b2e1b to
74bceb6
Compare
pinarol
approved these changes
Oct 29, 2019
Contributor
pinarol
left a comment
pinarol
left a comment
There was a problem hiding this comment.
I tested this with image and media-text blocks with this scenario, and it worked as expected:
- Add media & text and image block, tap placeholder and choose Choose from device
- Start upload image, before it finishes close the post by selecting Update Post
- Wait until the upload finishes
- Re-open the post
- Switch to html mode
- And mediaId was properly replaced:
I'll approve but let's also wait for @marecar3 's approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses wordpress-mobile/gutenberg-mobile#1509
This is not a full solution, but it will at least work for images uploaded via media-text in its default configuration. It still doesn't support video (since support wasn't there for the video block), and it will break if there are any other attributes before the id (such as alignment), but it's still an improvement.
We'll look for a better solution in 13.6.
To test:
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.