Implement File Block #13178

marecar3 · 2020-10-20T02:15:16Z

gutenberg PR: WordPress/gutenberg#26278
gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2743

This is a first step on implementing File Block.

This implementation only considers the basics:

Insert and render a File Block.
Upload a file from the iOS native Documents Picker.
- Don't let uploading file types not allowed by the blog.
Edit the file name and Download button text.

The rest of the features will be implemented in future PRs

CHOOSE A FILE

FILE UPLOADED

To test:

Add a File block.
Upload a file from the device.
- Check that you are able to upload images, videos, audio, pdf... but not allowed to upload txt files.
Check that you can edit the file name and the Download button text.
Check on HTML mode that the HREF is the remote one (not local).
Check on preview that you can download the uploaded file.

PR submission checklist:

I have considered adding unit tests where possible.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

peril-wordpress-mobile · 2020-10-20T02:15:21Z

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

peril-wordpress-mobile · 2020-10-20T02:27:27Z

You can test the changes on this Pull Request by downloading the APK here.

WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java

jd-alexander · 2020-10-27T00:40:19Z

Hey @marecar3 thanks for these changes. I know this is still marked as a draft but I still took a look 🙏 When I am running this code on my emulator and I try to add a file I get this exception below.

   Caused by: java.lang.IllegalArgumentException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkParameterIsNotNull, parameter mediaUri
        at org.wordpress.android.ui.posts.editor.media.EditorMedia.addNewMediaToEditorAsync(Unknown Source:2)
        at org.wordpress.android.ui.posts.EditPostActivity.onActivityResult(EditPostActivity.java:2663)
        at android.app.Activity.dispatchActivityResult(Activity.java:8310)

# Conflicts: # libs/gutenberg-mobile

marecar3 · 2020-10-27T20:48:46Z

Hey @marecar3 thanks for these changes. I know this is still marked as a draft but I still took a look 🙏 When I am running this code on my emulator and I try to add a file I get this exception below.

   Caused by: java.lang.IllegalArgumentException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkParameterIsNotNull, parameter mediaUri
        at org.wordpress.android.ui.posts.editor.media.EditorMedia.addNewMediaToEditorAsync(Unknown Source:2)
        at org.wordpress.android.ui.posts.EditPostActivity.onActivityResult(EditPostActivity.java:2663)
        at android.app.Activity.dispatchActivityResult(Activity.java:8310)

Thanks, @jd-alexander , I have fixed the issue and I have marked this PR as ready for review.

...ytics/WordPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTracker.java

WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java

...ressEditor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java

jd-alexander

Thanks for these changes @marecar3 I tested the File block's behavior and it worked as expected. I left a few comments for your consideration. Let me know what you think so that we can proceed. Thank you.

loremattei · 2020-11-02T11:45:53Z

Hey there! I'm moving this to 16.1 because 16.0 has been cut. If you want this to make it to 16.0, please feel free to ping me.

# Conflicts: # libs/gutenberg-mobile

…d/editor/gutenberg/GutenbergEditorFragment.java Co-authored-by: Joel Dean <[email protected]>

marecar3 · 2020-11-02T19:15:32Z

Hey @jd-alexander 👋
Thanks for the review.

I have pushed all changes.
Please do another round of testing so that can be sure that I didn't create any regression :) Thanks.

...ressEditor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java

jd-alexander

Thanks for these changes @marecar3 I have tested the changes as described in the PR description and all the functionality that's stated there is working. I have left a few comments for your perusal. Once you have reviewed them then we can finalize this and get it merged in.

# Conflicts: # libs/gutenberg-mobile

jd-alexander

Thanks for these changes @marecar3 I have updated the gb-mobile reference and all is well here. I will merge the changes once the build is green.

marecar3 · 2020-11-12T22:47:02Z

Thanks for these changes @marecar3 I have updated the gb-mobile reference and all is well here. I will merge the changes once the build is green.

Thanks to you as you did a great job with the review!

Update gb-mobile reference

4527c27

marecar3 added the gutenberg-mobile label Oct 20, 2020

marecar3 added 4 commits October 20, 2020 19:53

Update gb-mobile reference

bdd34a7

Add support for document files

661c94c

Upload selected document files

b6d44c8

Enable consolidated media picker

c9028f9

marecar3 mentioned this pull request Oct 21, 2020

[RNMobile] File block basics WordPress/gutenberg#26278

Merged

6 tasks

marecar3 marked this pull request as draft October 21, 2020 00:17

Fix lint error

af82450

etoledom mentioned this pull request Oct 21, 2020

File Block basics wordpress-mobile/gutenberg-mobile#2743

Merged

2 tasks

planarvoid reviewed Oct 21, 2020

View reviewed changes

WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java Outdated Show resolved Hide resolved

marecar3 added 4 commits October 27, 2020 13:57

Fix crash on Android and add tracking of document

9957e0f

Use native picker library

8de336a

remove unused request code

f4a1401

Remove unused code

f7b99a1

marecar3 requested a review from jd-alexander October 27, 2020 20:44

marecar3 added this to the 16.1 milestone Oct 27, 2020

marecar3 marked this pull request as ready for review October 27, 2020 20:46

Merge branch 'develop' into gutenberg/file-block

b358ff0

# Conflicts: # libs/gutenberg-mobile

marecar3 added 3 commits October 27, 2020 17:18

rename document to file in all appearances

a856bac

rename document to file in all appearances

c06f582

update gb mobile reference

91d89c1

jd-alexander reviewed Oct 28, 2020

View reviewed changes

...ytics/WordPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTracker.java Show resolved Hide resolved

jd-alexander reviewed Oct 28, 2020

View reviewed changes

WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java Show resolved Hide resolved

jd-alexander reviewed Oct 28, 2020

View reviewed changes

...ressEditor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java Show resolved Hide resolved

jd-alexander reviewed Oct 28, 2020

View reviewed changes

...ressEditor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java Outdated Show resolved Hide resolved

jd-alexander suggested changes Oct 28, 2020

View reviewed changes

loremattei modified the milestones: 16.1 ❄️, 16.2 Nov 2, 2020

marecar3 and others added 5 commits November 2, 2020 13:55

Merge branch 'develop' into gutenberg/file-block

8aff5b9

# Conflicts: # libs/gutenberg-mobile

Add proper case in getEventNameForStat for EDITOR_ADDED_FILE_VIA_LIBRARY

f85da5b

Convert media source statement to switch block

39bcb3f

Update libs/editor/WordPressEditor/src/main/java/org/wordpress/androi…

d04776c

…d/editor/gutenberg/GutenbergEditorFragment.java Co-authored-by: Joel Dean <[email protected]>

Fix renaming suggestion.

822cc6e

Add break to switch case

ffa5f7d

jd-alexander self-requested a review November 10, 2020 16:05

jd-alexander reviewed Nov 10, 2020

View reviewed changes

...ressEditor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java Outdated Show resolved Hide resolved

jd-alexander reviewed Nov 10, 2020

View reviewed changes

...ressEditor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java Outdated Show resolved Hide resolved

jd-alexander reviewed Nov 10, 2020

View reviewed changes

...ressEditor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java Outdated Show resolved Hide resolved

jd-alexander suggested changes Nov 10, 2020

View reviewed changes

marecar3 and others added 6 commits November 12, 2020 10:06

Merge branch 'develop' into gutenberg/file-block

14b0e59

# Conflicts: # libs/gutenberg-mobile

remove unnecessary check if arguments are null

11c593e

Align naming

741fb4d

Updated gutenberg ref

59ff6c9

Merge branch 'develop' into gutenberg/file-block

95fd639

Removed unneeded arguments and fixed typo

8d2b23c

jd-alexander approved these changes Nov 12, 2020

View reviewed changes

Updated gutenberg ref

d243c9e

etoledom changed the base branch from develop to gutenberg/after_1.41.0 November 13, 2020 10:26

Update gutenberg ref

3e07ac8

etoledom merged commit 1848053 into gutenberg/after_1.41.0 Nov 13, 2020

etoledom deleted the gutenberg/file-block branch November 13, 2020 12:42

ceyhun mentioned this pull request Nov 17, 2020

Gutenberg related changes to land after 16.2 App cut #13411

Merged

3 tasks

Implement File Block #13178

Implement File Block #13178

Uh oh!

Conversation

marecar3 commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peril-wordpress-mobile bot commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peril-wordpress-mobile bot commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jd-alexander commented Oct 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marecar3 commented Oct 27, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jd-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

loremattei commented Nov 2, 2020

Uh oh!

marecar3 commented Nov 2, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jd-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

jd-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

marecar3 commented Nov 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

marecar3 commented Oct 20, 2020 •

edited

Loading

peril-wordpress-mobile bot commented Oct 20, 2020 •

edited

Loading

peril-wordpress-mobile bot commented Oct 20, 2020 •

edited

Loading

jd-alexander commented Oct 27, 2020 •

edited

Loading