-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Gutenberg - Audio Block Processor #13575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
|
Hey! I've moved this to 16.5 because 16.4 has been cut. If you want this to make it to 16.4, please feel free to ping me. |
…tion' into gutenberg/audio-block-processor
mkevins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @jd-alexander 👍
Code looks good, and thanks for writing the tests too! I've tested this on Pixel 3a (physical device) and it's working as expected.
I left one minor suggestion. Other than that, LGTM!
...n/java/org/wordpress/android/ui/posts/mediauploadcompletionprocessors/AudioBlockProcessor.kt
Outdated
Show resolved
Hide resolved
…loadcompletionprocessors/AudioBlockProcessor.kt Utilized the local ID_ATTRIBUTE instead of the one from the FileBlockProcessor. Co-authored-by: Matthew Kevins <[email protected]>
|
👋 Hi @jd-alexander, the Gutenberg editor release 1.44.0 is being cut now (apologies for the late headsup), and I came across this PR. If this doesn't depend on a specific Gutenberg editor release, and can just be picked up by the main apps release in 16.5, no action is needed. |
|
I will merge this in when the parent PR is reviewed so that the diff of that PR isn't hard to read. |
|
I am merging this because the parent PR was mistakenly merged in and then reverted. Since this was already tested, it can be merged in, and when the parent PR is recreated it can branch from develop. |
Findings
This PR is the Android side of the iOS implementation for updating the HTML content of the Audio Block without Gutenberg being open.
Solution
The
AudioBlockProcessorreplaces the<audio src>tag that contains local file URL with a remote media URL once the file upload is complete. The id of the Audio Block is also updated with a remote variant as well.Testing
Verify that the behavior is functioning correctly by :
Reviewing
Submitter Checklist
RELEASE-NOTES.txtif necessary.