Revert "[Gutenberg] Audio block - Consolidated & Normal Media Picker Integration" #13805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
jd-alexander
approved these changes
Jan 18, 2021
Contributor
jd-alexander
left a comment
jd-alexander
left a comment
There was a problem hiding this comment.
Thanks @develric I did the smoke test with both pickers for the File, Image, Video block all works as expected. LGTM 🚢
jd-alexander
deleted the
revert-13612-gutenberg/audio_block_consolidated_media_picker_integration
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #13612
The above mentioned #13612 PR was merged by mistake since we need to wait for other GB PRs to be deployed first.
To test
Smoke test the new and old media picker in adding media (images/videos) from the editor and from the media library.