Skip to content

Conversation

@jd-alexander
Copy link
Contributor

@jd-alexander jd-alexander commented Jan 21, 2021

Gutenberg Mobile wordpress-mobile/gutenberg-mobile#3037
Gutenberg WordPress/gutenberg#27467

Solution

Showcases the Audio Player UI with Consolidated Media Picker for file picking.

Testing

  1. Create a new post.
  2. Add an Audio Block.
  3. Add an audio file from the device to see upload in progress and success state.
  4. Add an audio file from the device while in airplane mode to see the error state.

Success

Light Mode Dark Mode

Uploading

Light Mode Dark Mode

Error

Light Mode Dark Mode

Reviewing

Only 1 reviewer is needed but anyone can review.

Submitter Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
  • I have considered adding accessibility improvements for my changes.
  • If it's feasible, I have added unit tests.

@jd-alexander jd-alexander added this to the 16.7 milestone Jan 21, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 21, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 21, 2021

You can test the changes on this Pull Request by downloading the APK here.

Base automatically changed from gutenberg/audio_block_consolidated_media_picker_integration to develop January 28, 2021 22:17
@jd-alexander
Copy link
Contributor Author

This PR needs to be synced with develop so that it can pass. I am going to do that now.

@jd-alexander
Copy link
Contributor Author

Closing this PR since the ongoing editor release will include these changes for WP Android.

@jkmassel jkmassel deleted the gutenberg/audio_block_player_ui branch October 17, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants