Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Jul 9, 2021

Description

Adds a new analytics event emitted when the editor settings are fetched

  • Event Name: editor_settings_fetched
  • Properties
    • full_site_editing = true or false
    • endpoint = theme_supports or wp-block-editor

Depends on

WordPress-FluxC-Android PR: wordpress-mobile/WordPress-FluxC-Android#2051
Events registration: https://github.com/Automattic/tracks-events-registration/pull/517

To test:

FSE Theme with /wp-block-editor/v1/settings

  1. Set up a site that uses a FSE theme, and enable the GSS Settings via the debug options
  2. Navigate to the editor
  3. Verify that an event is emitted: editor_settings_fetched, Properties: {"endpoint":"wp-block-editor","full_site_editing":true}

Traditional Theme with /wp-block-editor/v1/settings

  1. Set up a site that is using a non-FSE theme, and enable the GSS Settings via the debug options
  2. Navigate to the editor
  3. Verify that an event is emitted: editor_settings_fetched, Properties: {"endpoint":"wp-block-editor","full_site_editing":false}

Traditional Theme with /wp/v2/themes

  1. Set up a site that is using a non-FSE theme, and diable the GSS Settings or select a self-hosted site with the base WP install
  2. Navigate to the editor
  3. Verify that an event is emitted: editor_settings_fetched, Properties: {"endpoint":"theme_supports","full_site_editing":false}

📓 Notes:

  • The common editor event properties are also emitted along the two new specific ones to align with the rest of the editor events and be able to gather extra information if needed
  • The Jetpack side is still dependent on some backend changes so this PR is still a draft.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 9, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 9, 2021

You can test the changes on this Pull Request by downloading the APKs:

@antonis antonis marked this pull request as ready for review July 13, 2021 13:18
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @antonis every thing is working as expected wordpress-mobile/WordPress-FluxC-Android#2051 (review)

@antonis antonis merged commit 607a355 into develop Jul 15, 2021
@antonis antonis deleted the issue/gssAnalytics branch July 15, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants