-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Block Editor Settings: Adds Analytics to track which endpoints are being used #15009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
# Conflicts: # build.gradle
# Conflicts: # build.gradle
chipsnyder
approved these changes
Jul 14, 2021
Contributor
chipsnyder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @antonis every thing is working as expected wordpress-mobile/WordPress-FluxC-Android#2051 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new analytics event emitted when the editor settings are fetched
editor_settings_fetchedfull_site_editing=trueorfalseendpoint=theme_supportsorwp-block-editorDepends on
WordPress-FluxC-AndroidPR: wordpress-mobile/WordPress-FluxC-Android#2051Events registration: https://github.com/Automattic/tracks-events-registration/pull/517
To test:
FSE Theme with /wp-block-editor/v1/settings
editor_settings_fetched, Properties:{"endpoint":"wp-block-editor","full_site_editing":true}Traditional Theme with /wp-block-editor/v1/settings
editor_settings_fetched, Properties:{"endpoint":"wp-block-editor","full_site_editing":false}Traditional Theme with /wp/v2/themes
editor_settings_fetched, Properties:{"endpoint":"theme_supports","full_site_editing":false}📓 Notes:
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.