Remove explore plans from Quick start

[AjeshRPai]

Fixes #16477

This PR removes the Explore Plans task from the quick start list and card.

Internal Reference: p1651666551282059/1651587009.445519-slack-C011BKNU1V5
Corresponding FluxC PR: wordpress-mobile/WordPress-FluxC-Android#2409

Before	After

---

To test:

Test 1

Explore Plans is Not Shown on Quickstart list

1. Login to the app with a quick start in progress
2. Click on My Site -> Next Steps Card
3. Notice that Explore Plans quick start task is not displayed

Test 2 - Migration

Scenario - Test the case where all Quickstart tasks other than Explore Plan is completed, In this task completed notification should be shown to the user in Notifications tab

Pre- requisites
For this test, install an app having the Explore Plans listed,

1. Login to the app with a quick start in progress
2. Complete all tasks other than Explore Plans
3. Checkout to this branch or Install the build from this PR
4. Notice that Explore Plans is not displayed and Quick start is completed

---

Merge Instructions

1. Make sure the dependent FluxC PR is merged
2. Update FluxC hash
3. Remove Not Ready for Merge

Regression Notes

1. Potential unintended areas of impact

• Quickstart progress not shown properly
• Explore plans tasks being shown

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   Manual testing

3. What automated tests I added (or what prevented me from doing so)
   N/A

---

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

[peril-wordpress-mobile]

You can test the changes on this Pull Request by downloading the APKs:

• Jetpack-pr-16582-build-123832.apk

• WordPress-pr-16582-build-123832.apk

[ashiagr]

Thanks for this PR, @AjeshRPai!

Overall I find the changes fine, except that in the migration test - step 4 since all Quick Start tasks are complete on installing the app from this PR branch, I would have expected following actions:

1. Show Quick Start completion notification.
2. Hide Quick Start card.

Currently, I see that Quick Start card is shown with all items stuck off. It's not hidden even on pull-to-refresh.

qs-card-shown-all-tasks-completed.mp4

It looks like

1. When we install an app having the Explore Plans listed, and only the Plans task is left incomplete, Quick Start is not marked complete in the DB which should have happened here.

2. Then when we launch the app from this PR branch, we show a completion notification if every task is marked complete for the site and the completion notification is not yet received. On refreshing the screen, since Quick Start is still in progress, the card keeps displaying.

I think we can resolve this issue if we mark Quick Start complete explicitly (if not already complete) when we check that all tasks are complete on app launch before sending the completion notification. Let me know if it makes sense. 😅

[AjeshRPai]

Hey @ashiagr , Thanks for reviewing the PR.

I was expecting that scenario to work properly as I had tested the scenario you had described in my local and I got

• Show Quick Start completion notification.
• Hide Quick Start card.

I am not sure what went wrong here, I will look into this on priority

I think we can resolve this issue if we mark Quick Start complete explicitly (if not already complete) when we check that all tasks are complete on app launch before sending the completion notification. Let me know if it makes sense. 😅

I think this will work. Working on a fix 👍🏼

[wpmobilebot]

Found 1 violations:

The PR caused the following dependency changes:

-+--- org.wordpress:fluxc:{strictly 1.42.0} -> 1.42.0
-|    +--- org.wordpress:wellsql:1.7.0
-|    |    \--- org.wordpress.wellsql:wellsql-annotations:1.7.0
-|    +--- org.wordpress.fluxc:fluxc-annotations:1.42.0
-|    +--- org.greenrobot:eventbus:3.3.1 (*)
-|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.9.2 (*)
-|    +--- com.android.volley:volley:1.1.1 -> 1.2.0
-|    +--- androidx.paging:paging-runtime:2.1.2
-|    |    +--- androidx.paging:paging-common:2.1.2
-|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.1.0 (*)
-|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.1.0 (*)
-|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.3.1 (*)
-|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.2.0 (*)
-|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0 (*)
-|    +--- com.goterl:lazysodium-android:5.0.2
-|    +--- net.java.dev.jna:jna:5.5.0
-|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
-|    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.10 (*)
-|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.3.1 (*)
-|    +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0 (*)
-|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.1.0-beta01 (*)
-|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2
-|    |    +--- com.squareup.okhttp3:okhttp:4.9.2 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.6.10 (*)
-|    +--- com.google.code.gson:gson:2.8.5
-|    +--- org.apache.commons:commons-text:1.1 (*)
-|    +--- androidx.room:room-runtime:2.4.2 (*)
-|    +--- androidx.room:room-ktx:2.4.2
-|    |    +--- androidx.room:room-common:2.4.2 (*)
-|    |    +--- androidx.room:room-runtime:2.4.2 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
-|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
-|    +--- com.google.dagger:dagger:2.29.1 -> 2.41 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.5.2 (*)
-|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.5.2 (*)
++--- org.wordpress:fluxc:{strictly 1.42.1} -> 1.42.1
+|    +--- org.wordpress:wellsql:1.7.0
+|    |    \--- org.wordpress.wellsql:wellsql-annotations:1.7.0
+|    +--- org.wordpress.fluxc:fluxc-annotations:1.42.1
+|    +--- org.greenrobot:eventbus:3.3.1 (*)
+|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.9.2 (*)
+|    +--- com.android.volley:volley:1.1.1 -> 1.2.0
+|    +--- androidx.paging:paging-runtime:2.1.2
+|    |    +--- androidx.paging:paging-common:2.1.2
+|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
+|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.1.0 (*)
+|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.1.0 (*)
+|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.3.1 (*)
+|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.2.0 (*)
+|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0 (*)
+|    +--- com.goterl:lazysodium-android:5.0.2
+|    +--- net.java.dev.jna:jna:5.5.0
+|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
+|    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.10 (*)
+|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.3.1 (*)
+|    +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0 (*)
+|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.1.0-beta01 (*)
+|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2
+|    |    +--- com.squareup.okhttp3:okhttp:4.9.2 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.6.10 (*)
+|    +--- com.google.code.gson:gson:2.8.5
+|    +--- org.apache.commons:commons-text:1.1 (*)
+|    +--- androidx.room:room-runtime:2.4.2 (*)
+|    +--- androidx.room:room-ktx:2.4.2
+|    |    +--- androidx.room:room-common:2.4.2 (*)
+|    |    +--- androidx.room:room-runtime:2.4.2 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
+|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
+|    +--- com.google.dagger:dagger:2.29.1 -> 2.41 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.5.2 (*)
+|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.5.2 (*)
 \--- org.wordpress:login:0.14.0
-     \--- org.wordpress:fluxc:trunk-1436f46fc296ede0e65e117bbfced38fa34cec6d -> 1.42.0 (*)
+     \--- org.wordpress:fluxc:trunk-1436f46fc296ede0e65e117bbfced38fa34cec6d -> 1.42.1 (*)

Please review and act accordingly

[AjeshRPai]

@ashiagr Thanks for the Input and all the help. The issue you have mentioned in the PR have been fixed by the commit b7dfd15. I have implemented the solution you had described. Thanks for the help.

Now, if only the plans item is remaining before this PR, then after installing the app from this PR the user will

• Will see a Quick Start completion notification.
• Will not see the Quick Start card.

[ashiagr]

Thanks for the fix! All looks good to me now.