Skip to content

Conversation

@AjeshRPai
Copy link
Contributor

Fixes #16603

This PR Fixes focus Point not animating after switching tabs. If a user switches between the tabs while the quick start focus point is shown in the list item in My Site. The quick start focus point animation freezes.

After Fix
https://user-images.githubusercontent.com/17463767/169389502-8b25695e-09c7-40d3-b332-6b38751cd8a0.mp4

To test:

  1. Login to the app with a quick start in progress
  2. Start a quick start which has a quick start focus point in Dashboard list or Site Menu list
  3. Notice that the focus point is being displayed
  4. Switch to the other tab (if Home then switch to Menu)
  5. Switching to the original tab
  6. Verify that the focus point animation is still seen

Regression Notes

  1. Potential unintended areas of impact
  • My Site items(dashboard and menu) not being displayed properly
  • Quick start focus point not being shown properly
  1. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  2. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 19, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@AjeshRPai AjeshRPai requested a review from ashiagr May 19, 2022 19:44
@AjeshRPai AjeshRPai added this to the 19.9 ❄️ milestone May 19, 2022
@AjeshRPai AjeshRPai marked this pull request as ready for review May 19, 2022 19:44
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 19, 2022

You can test the changes on this Pull Request by downloading the APKs:

@ashiagr ashiagr self-assigned this May 20, 2022
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
:shipit:

@ashiagr ashiagr merged commit cc024b4 into release/19.9 May 20, 2022
@ashiagr ashiagr deleted the fix/focus-point-not-being-shown-switching-tabs branch May 20, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants