Skip to content

Conversation

@ashiagr
Copy link
Contributor

@ashiagr ashiagr commented May 20, 2022

Parent #16542

This PR tracks the quick start card shown event for my site tabs.
Internal Ref: p1652980710237019-slack-C0290FLA0RM

To test:

Prerequisite: Enable tracking using Me -> App Settings -> Privacy settings -> Collect information.

  1. Launch the app.
  2. Logout/login and select "Show me around" when the quick start prompt is shown.
  3. Select an existing site.
  4. Go to My Site tab.
  5. If "Home" tab is selected by default, notice that my_site_dashboard_card_shown event is tracked for quick start card (this tracking is added to shown qs card is shown on home/dashboard tab along with other dashboard cards):
    🔵 Tracked: my_site_dashboard_card_shown, Properties: {"type":"quick_start","default_tab_experiment":<value>,"subtype":"quick_start_existing_site"}
  6. If "Home" tab is not selected by default, select "Home" tab using "Initial Screen" setting.
  7. Notice that my_site_dashboard_card_shown event is tracked for quick start card.
  8. Notice that following events are also tracked along with tab and site_type properties (this tracking is added to track qs card shown event for site menu tab as well):
    🔵 Tracked: quick_start_card_shown, Properties: {"tab":"site_menu","site_type":"existing_site","default_tab_experiment":<value>}
    🔵 Tracked: quick_start_card_shown, Properties: {"tab":"dashboard","site_type":"existing_site","default_tab_experiment":"<value>}

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ashiagr ashiagr added this to the 19.9 ❄️ milestone May 20, 2022
@ashiagr ashiagr requested a review from AjeshRPai May 20, 2022 05:57
@ashiagr ashiagr self-assigned this May 20, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 20, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 20, 2022

You can test the changes on this Pull Request by downloading the APKs:

@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

Copy link
Contributor

@AjeshRPai AjeshRPai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashiagr Tested according to instructions. All events were tracked as described. Also, code changes look good to me. 👍🏼

@AjeshRPai AjeshRPai merged commit a377914 into release/19.9 May 20, 2022
@AjeshRPai AjeshRPai deleted the issue/track-qs-card-shown branch May 20, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants