Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Jun 2, 2022

Fixes #

To test:

  1. Start the site creation flow
  2. Proceed to the site design picker
  3. Verify that there is a margin between the recommended title and subtitle
Before After
s1 s3

Regression Notes

  1. Potential unintended areas of impact
    Page layout picker

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

Before After
l1 l3
  1. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @antonis! I tested on a Pixel 4a. 🚀

@twstokes twstokes merged commit f6d7e87 into feature/site-design-revamp Jun 2, 2022
@twstokes twstokes deleted the task/site-design-revamp-subtitle-margin branch June 2, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants