Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Jun 2, 2022

Removes the pink selection border when the preview is collapsing (ref: pc8HXX-oi-p2#comment-503)

To test:

  1. Start the site creation flow
  2. Proceed to the design picker
  3. Select a layout
  4. slowly dismiss the preview
  5. Verify that no selection border is visible (like below)
    Screenshot 2022-06-02 at 4 48 14 PM

Regression Notes

  1. Potential unintended areas of impact
    Page Layout picker

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    The fix was in the UI layer that would be hard to test with the current code structure

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested Jetpack-pr-16693-build-124718.apk and it works as described. 🥳

I also tested the Page Layout picker and didn't spot any regressions. Thanks @antonis!

@twstokes twstokes added this to the 20.1 milestone Jun 2, 2022
@twstokes twstokes merged commit 0abd1f3 into feature/site-design-revamp Jun 2, 2022
@twstokes twstokes deleted the task/site-design-revamp-remove-overlay branch June 2, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants