Skip to content

[Site Design Revamp] Fix blank theme preview after orientation change #16700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 2 commits into from
Jun 3, 2022
Merged

[Site Design Revamp] Fix blank theme preview after orientation change #16700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f39946e
Save view model data in home page picker fragment on orientation changes
mkevins Jun 3, 2022
591dddf
Remove writing theme picker vm to activity bundle
mkevins Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion WordPress/src/main/java/org/wordpress/android/ui/sitecreation/SiteCreationActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ class SiteCreationActivity : LocaleAwareActivity(),
override fun onSaveInstanceState(outState: Bundle) {
super.onSaveInstanceState(outState)
mainViewModel.writeToBundle(outState)
hppViewModel.writeToBundle(outState)
}

private fun observeVMState() {
Expand Down
5 changes: 5 additions & 0 deletions ...Press/src/main/java/org/wordpress/android/ui/sitecreation/theme/HomePagePickerFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ class HomePagePickerFragment : Fragment() {
}
}

override fun onSaveInstanceState(outState: Bundle) {
super.onSaveInstanceState(outState)
viewModel.writeToBundle(outState)
}

private fun HomePagePickerFragmentBinding.setupUi() {
siteCreationThemeHeader.title?.setText(R.string.hpp_title)
siteCreationThemeHeader.subtitle?.isGone = true
Expand Down