Skip to content

Conversation

@AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Jun 15, 2022

What

@tobifjellner spotted a typo in a newly-introduced string in WPAndroid 20.1 and reported it to us here in the WPorg slack

One string contains an error, at least in Android. String ref: stats_referrers_pie_chart_wordpress and contains the string "Wordpress" (with lowercase p)

This PR simply fixes the typo so it gets re-imported into GlotPress.

How

  • Fixed the typo in WordPress/src/main/res/values/strings.xml
  • Re-ran bundle exec fastlane update_frozen_strings_for_translation so that the typo gets included in the frozen strings file that are imported by GlotPress (fastlane/resources/values/strings.xml) via cron

ℹ️ This PR targets the release/20.1 since this typo fix will have to be included in the next 20.1 beta and final release.
Once this PR lands in release/20.1, I will follow-up with a PR to merge release/20.1 into trunk so that the new fastlane/resources/values/strings.xml lands in trunk and gets picked up and re-imported by GlotPress

To test:

Nothing to test, it's just a typo fix. The typo fix will ship in the next beta that we will do later this sprint.

@AliSoftware AliSoftware added Releases Label related to managing releases Localization labels Jun 15, 2022
@AliSoftware AliSoftware added this to the 20.1 ❄️ milestone Jun 15, 2022
@AliSoftware AliSoftware requested a review from a team June 15, 2022 09:25
@AliSoftware AliSoftware self-assigned this Jun 15, 2022
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@AliSoftware AliSoftware changed the title L10n/fix typo Fix a typo in a newly-introduced string for 20.1 Jun 15, 2022
@AliSoftware AliSoftware enabled auto-merge June 15, 2022 09:26
@ParaskP7 ParaskP7 self-assigned this Jun 15, 2022
Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@AliSoftware AliSoftware merged commit d570096 into release/20.1 Jun 15, 2022
@AliSoftware AliSoftware deleted the l10n/fix-typo branch June 15, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Localization Releases Label related to managing releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants