Stats Revamp v2: Fix date problem on line chart #16754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line chart dates were showing as "null" on some devices. I tried to find the reason by using different languages, locales, but every time it was null. It's not showing as null on @ravishanker 's device.
To test:
Regression Notes
Potential unintended areas of impact
The date label might be changed incorrectly on other devices which don't show null before.
What I did to test those areas of impact (or what existing automated tests I relied on)
I could test only on my device. I'll ask Ravi to test in his environment. His device wasn't shown null before.
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.