Skip to content

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Sep 8, 2022

We normally merge the code freeze once the associated first beta build has been submitted to Google Play. In this instance, because of the 20.6.1 hotfix work which still hasn't been merged together with what was most likely a Google Play bug (as reported by other folks, too) we haven't been yet able to submit.

It's useful to merge even if the usual requirements haven't been satisfied because we need the frozen strings, see 8239864, to be sent up to GlotPress for translation.


  • New version header in RELEASE-NOTE.txt
  • Version updates in version.properties
  • release_notes.txt updated with notes from RELEASE-NOTE.txt for current version
  • strings.xml updates via automation merging values from libraries
  • Switched ext versions to stable releases

@mokagio mokagio requested a review from a team September 8, 2022 03:11
@mokagio mokagio added the Releases Label related to managing releases label Sep 8, 2022
@mokagio mokagio self-assigned this Sep 8, 2022
@mokagio mokagio added this to the 20.7 ❄️ milestone Sep 8, 2022
@mokagio mokagio enabled auto-merge September 8, 2022 03:11
@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused the following dependency changes:

-\--- org.wordpress:login:trunk-692264f8a2a0efa540b7713d3e1ad7fc09b87d47
+\--- org.wordpress:login:0.19.0

Please review and act accordingly

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 8, 2022

You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr17145-afb680b.apk), or scanning this QR code:

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 8, 2022

You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr17145-afb680b.apk), or scanning this QR code:

@mokagio mokagio changed the title Merge **unreleased** 20.7 code freeze into trunk Merge **unreleased** 20.7 code freeze and editorialized release notes into trunk Sep 8, 2022
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for wrangling this @mokagio 🙇
The code changes look consistent to me and the apps behave as expected 🎉

Note: I've noticed an issue with the Google login flow but this is also reproducible on trunk. I'll investigate further and report in a separate issue.

@mokagio mokagio merged commit cdb7eab into trunk Sep 8, 2022
- Jetpack widgets are now available on your device’s home screen
- Media preview controls are visible in both light and dark mode
- Compose theme’s Login Code screen has better color contrast
- Certain elements of the editor and post settings are now WordPress blue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Jetpack release notes yet we're talking about links being changed from green to WordPress blue… suspicious … wasn't that entry supposed to be on the WordPress release notes instead of the Jetpack one? 🤔

cc @SiobhyB @dcalhoun @mokagio

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AliSoftware, thanks for double-checking here! As we chatted about in Slack too, the release notes here are correct. There were a lot of blue/green colour clashes in the editor in the Jetpack app, which looked pretty off-putting. Following the discussions in wordpress-mobile/gutenberg-mobile#4889 and wordpress-mobile/gutenberg-mobile#5047, we decided to change the colours in the editor from green to blue in the Jetpack app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Releases Label related to managing releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants