-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Merge **unreleased** 20.7 code freeze and editorialized release notes into trunk
#17145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Found 1 violations: The PR caused the following dependency changes:-\--- org.wordpress:login:trunk-692264f8a2a0efa540b7713d3e1ad7fc09b87d47
+\--- org.wordpress:login:0.19.0
Please review and act accordingly
|
|
You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr17145-afb680b.apk), or scanning this QR code: |
|
You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr17145-afb680b.apk), or scanning this QR code: |
trunktrunk
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for wrangling this @mokagio 🙇
The code changes look consistent to me and the apps behave as expected 🎉
Note: I've noticed an issue with the Google login flow but this is also reproducible on trunk. I'll investigate further and report in a separate issue.
| - Jetpack widgets are now available on your device’s home screen | ||
| - Media preview controls are visible in both light and dark mode | ||
| - Compose theme’s Login Code screen has better color contrast | ||
| - Certain elements of the editor and post settings are now WordPress blue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AliSoftware, thanks for double-checking here! As we chatted about in Slack too, the release notes here are correct. There were a lot of blue/green colour clashes in the editor in the Jetpack app, which looked pretty off-putting. Following the discussions in wordpress-mobile/gutenberg-mobile#4889 and wordpress-mobile/gutenberg-mobile#5047, we decided to change the colours in the editor from green to blue in the Jetpack app.
We normally merge the code freeze once the associated first beta build has been submitted to Google Play. In this instance, because of the 20.6.1 hotfix work which still hasn't been merged together with what was most likely a Google Play bug (as reported by other folks, too) we haven't been yet able to submit.
It's useful to merge even if the usual requirements haven't been satisfied because we need the frozen strings, see 8239864, to be sent up to GlotPress for translation.
RELEASE-NOTE.txtversion.propertiesrelease_notes.txtupdated with notes fromRELEASE-NOTE.txtfor current versionstrings.xmlupdates via automation merging values from librariesextversions to stable releases