Skip to content

Avoid Gutenberg reload times on rotation #8790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mzorz wants to merge 1 commit into from
Closed

Avoid Gutenberg reload times on rotation #8790

mzorz wants to merge 1 commit into from

Conversation

@mzorz
Copy link
Contributor

@mzorz mzorz commented Dec 14, 2018 •
edited
Loading

This PR uses setRetainInstance(true) to keep the ReactNative host fragment from being re-created on rotation.

To test:

  1. open a Gutenberg post on WPAndroid (with Gutenberg enabled in settings)
  2. rotate the device
  3. observe the content is still there and it doesn't take as long as previously to load

Corresponding mobile Gutenberg PR: wordpress-mobile/gutenberg-mobile#382

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@mzorz mzorz added this to the 11.5 milestone Dec 14, 2018
This was referenced Dec 14, 2018
Closed
Closed
@mzorz
Copy link
Contributor Author

mzorz commented Dec 17, 2018

Closing in favor of #8800

@mzorz mzorz closed this Dec 18, 2018
@mzorz mzorz deleted the fix/RN-reload-time-on-rotation branch February 19, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

[Status] Not Ready for Review

Projects

None yet

Milestone

11.5 ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@mzorz