Skip to content

[Gutenberg] Fix for editor not initialized if title is empty #9153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mzorz merged 1 commit into from
Jan 30, 2019
Merged

[Gutenberg] Fix for editor not initialized if title is empty #9153

mzorz merged 1 commit into from
Jan 30, 2019

Conversation

@daniloercoli
Copy link
Contributor

@daniloercoli daniloercoli commented Jan 30, 2019

This PR fixes #9144 by making sure to set the title for GutenbergEditorFragment so RN gets initialized.

To test:

  • Enable Gutenberg
  • Create New Post
  • Put some paragraph
  • Leave title EMPTY
  • Press back arrow
  • Open the drafted Post and check the editor is started properly

Update release notes:

  • [ x ] If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@daniloercoli daniloercoli added this to the 11.8 milestone Jan 30, 2019
@mzorz mzorz self-assigned this Jan 30, 2019
@hypest hypest mentioned this pull request Jan 30, 2019
Closed
@mzorz
Copy link
Contributor

mzorz commented Jan 30, 2019

While this PR fixes the problem described in #9144, I found out this following other issue:

  1. enter some title and some paragraph with text
  2. rotate the device
  3. observe it's all good
  4. delete the title entirely
  5. rotate the device
  6. observe the title appears again as in point 3.

This might be related to issue described in #9148. Will try on develop and confirm.

@mzorz
Copy link
Contributor

mzorz commented Jan 30, 2019

Confirmed this issue is unrelated to this PR, but probably saved in #9030. Will follow up there 👍

mzorz
mzorz approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@mzorz mzorz merged commit 495788a into develop Jan 30, 2019
@mzorz mzorz deleted the issue/9144-gb-not-initialized-for-post-with-empty-title branch January 30, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mzorz mzorz mzorz approved these changes

@marecar3 marecar3 Awaiting requested review from marecar3

Assignees

@mzorz mzorz

Labels

None yet

Projects

None yet

Milestone

11.8

Development

Successfully merging this pull request may close these issues.

Gutenberg won't be initialized if title is empty on drafted post

3 participants

@daniloercoli @mzorz