This repository was archived by the owner on Feb 4, 2025. It is now read-only.
Fetch order summaries after adding a new order #2436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
nbradbury
reviewed
Jun 7, 2022
| } else { | ||
| val model = result.result!! | ||
| ordersDao.insertOrUpdateOrder(model) | ||
| dispatcher.dispatch( |
Contributor
There was a problem hiding this comment.
This change is good, I simply recommend adding a comment explaining why we fetch the order list here.
nbradbury
approved these changes
Jun 7, 2022
Contributor
nbradbury
left a comment
nbradbury
left a comment
There was a problem hiding this comment.
Thanks for this change! 
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to fix the issue woocommerce/woocommerce-android#6693
Check the PR woocommerce/woocommerce-android#6706 for details.